Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Registry to the supported list #1525

Closed
marc-x-andre opened this issue Jan 3, 2020 · 7 comments
Closed

Add Github Registry to the supported list #1525

marc-x-andre opened this issue Jan 3, 2020 · 7 comments

Comments

@marc-x-andre
Copy link

Github as is own package registry, docker.pkg.github.com, that can be used as a docker registry.

Connecting as a Generic Docker Registry result to 404 page not found error. Maybe the API is different.

More info about Github packages

It could be nice to add Github registry to the list of providers.

@philliphoff
Copy link
Member

@the224 It appears that the Github Package Docker Registry does not support the _catalog API used to list the repositories within the registry. I can't find any information about the extent to which Github supports the (V2) API for Docker registries. It does appear to support, for example, listing tags for a given image.

@Phanatic Would you be able to point me to information about Github's support for the Docker registry API?

@Phanatic
Copy link

Phanatic commented Jan 7, 2020

@philliphoff we don't support the _catalog endpoint in the GitHub Docker Registry today.
I can open an issue to track this, which other API endpoints are necessary for this extension to work?
I can check and create issues for any missing support from the Docker HTTP API spec

@philliphoff
Copy link
Member

@Phanatic Our extension creates a tree view for Docker registries, listing each repository in a registry and then each tag within a repository, which means supporting at least the _catalog and <repo>/tag/list endpoints. It then allows the user to pull/delete an entire repository, or to pull/untag/delete/get-digest-for individual images. Some of those commands go through the Docker command line, while others use the HTTP API directly (via a Node.js client library), so it's somewhat tedious to identify the exhaustive list of endpoints used, but the closer GitHub can get to 100% coverage of the (V2) spec, the more likely the tools will "just work".

@dbreshears
Copy link
Member

@Phanatic, is there an issue logged that we can track and any current status / eta on this? This is a frequent request for a Docker extension container registry feature

@dbreshears dbreshears added this to the Future milestone Jan 17, 2020
@bwateratmsft
Copy link
Collaborator

@Phanatic Do you know where we can create/track issues on the API?

@bwateratmsft
Copy link
Collaborator

For now I'll resolve this as a dupe of #869, we are tracking GitHub support there.

@jayarjo
Copy link

jayarjo commented Mar 28, 2020

Everybody involved in this, please proceed. @Phanatic please cooperate.

@bwateratmsft bwateratmsft removed this from the Future milestone Mar 31, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants