Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellisense should stop "helping" inside comments #165

Closed
ssteinerx opened this issue Nov 7, 2017 · 8 comments
Closed

Intellisense should stop "helping" inside comments #165

ssteinerx opened this issue Nov 7, 2017 · 8 comments

Comments

@ssteinerx
Copy link

This only seems to happen with the Docker support.

Inside a comment in a Dockerfile, it's almost impossible to just type 'cause "helpful" suggestions pop up constantly.

# at the beginning of a line starts a comment and everything else after that should be left alone for regular typing.

@rcjsuen
Copy link
Contributor

rcjsuen commented Nov 8, 2017

Hi @ssteinerx, thank you for the bug report.

Could you attach a screenshot that shows what you are seeing? I want to ensure that the behavior I am seeing matches what you are encountering.

@ssteinerx
Copy link
Author

Pretty simple...
# to start a comment
<space> brings up a list of Docker commands and makes typing virtually impossible

vscode-helpful-docker

@rcjsuen
Copy link
Contributor

rcjsuen commented Nov 10, 2017

Thank you very much for the screenshot, @ssteinerx. I've fixed rcjsuen/dockerfile-language-server#190.

@ssteinerx
Copy link
Author

@rcjsuen Thanks! How would one get that updated into their VSCode installation? At the moment, mine says there are no updates available. Does it require also pushing an update to this extension? Thanks again!

@rcjsuen
Copy link
Contributor

rcjsuen commented Nov 10, 2017

@ssteinerx The bug is in one of the dependencies of the the vscode-docker extension. It would require both an update to the dependency and an update to the extension (to increment the version of the dependency).

@rcjsuen
Copy link
Contributor

rcjsuen commented Jan 10, 2018

I think we can close this since #173 has been merged?

@ssteinerx
Copy link
Author

@rcjsuen Is this supposed to be in most recent code insiders release?

@rcjsuen
Copy link
Contributor

rcjsuen commented Jan 11, 2018

@ssteinerx The fix should be in the 0.0.23 release of this extension that was published on January 6th.

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants