Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate running docker context inspect only if needed #1818

Closed
bwateratmsft opened this issue Apr 3, 2020 · 1 comment · Fixed by #1823
Closed

Investigate running docker context inspect only if needed #1818

bwateratmsft opened this issue Apr 3, 2020 · 1 comment · Fixed by #1823
Milestone
1.1.0

Comments

@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Apr 3, 2020 •
edited
Loading

Since docker context inspect takes some time (docker/cli#2420), but many people wouldn't be using it, we can save some activation time by only calling it if there's more than just the default context. default cannot be modified, it is always based on DOCKER_HOST, which we cover already with our environment variable logic.

If any folders exist in ~/.docker/contexts/meta, there are some custom contexts, and we should use docker context inspect; but if that folder is empty we shouldn't have to call it.
@bwateratmsft
Copy link
Collaborator Author

Need to investigate if this is feasible.

@bwateratmsft bwateratmsft changed the title Run docker context inspect only if there's more than the default context Investigate running docker context inspect only if there's more than the default context Apr 3, 2020
@bwateratmsft bwateratmsft changed the title Investigate running docker context inspect only if there's more than the default context Investigate running docker context inspect only if needed Apr 3, 2020
@dbreshears dbreshears added this to the 1.1.0 milestone Apr 3, 2020
This was referenced Apr 6, 2020
Closed
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Call docker context inspect only when needed microsoft/vscode-docker
3 participants
@dbreshears @karolz-ms @bwateratmsft