Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildkit builds have very ugly output #2451

Closed
bwateratmsft opened this issue Oct 29, 2020 · 3 comments · Fixed by #2460
Closed

Buildkit builds have very ugly output #2451

bwateratmsft opened this issue Oct 29, 2020 · 3 comments · Fixed by #2460
Labels
enhancement fix released investigate
Milestone
1.8.0

Comments

@bwateratmsft
Copy link
Collaborator

image

These aren't errors but they certainly look intimidating.
@bwateratmsft bwateratmsft added this to the 1.8.0 milestone Oct 29, 2020
@bwateratmsft bwateratmsft self-assigned this Oct 29, 2020
@bwateratmsft bwateratmsft changed the title Lots and lots of red text in Docker build output Buildkit builds have very ugly output Oct 30, 2020
@bwateratmsft
Copy link
Collaborator Author

Buildkit builds look a whole lot nicer through a TTY. We should see if we can support that instead of the direct output we have now.

@bwateratmsft
Copy link
Collaborator Author

I think this would also improve the output experience when pulling images.

@bwateratmsft bwateratmsft mentioned this issue Nov 3, 2020
Merged
@bwateratmsft bwateratmsft removed their assignment Nov 9, 2020
@bwateratmsft
Copy link
Collaborator Author

This fix has now been released in 1.8.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement fix released investigate
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

Don't use red text for stderr in DockerPseudoTerminal microsoft/vscode-docker
1 participant
@bwateratmsft