An error "No containers are available to restart" occurs when restarting a stopped container in the ACI context environment

[v-ruizh]

OS: Windows 10
Build Version: 20210106.8

Repro Steps:

1. Right click one ACR image -> Select "Deploy Image to Azure Container Instances..." and create one new ACI.
2. Stop the container in the ACI context environment.
3. F1 -> Docker Container: Restart.

Expect:
Wizard to the container option.

Actual:
An error "No containers are available to restart" occurs.

More Info:
This issue does not reproduce in default context environment.

[bwateratmsft]

Found the root cause. ACI added some new state strings, "Node Pending" (starting), and "Node Stopped" (stopped). Both should be treated as stopped states (for purposes of the icon), but "Node Stopped" should also show the "Start" action.

[bwateratmsft]

I've found that the container does not always transition to "Node Stopped". Eventually it always ends up at "Terminated", but sometimes it seems to skip "Node Stopped". So far I have not seen it skip "Node Pending", but it's probably safe to assume that is a possibility.

[bwateratmsft]

There's one remaining issue. For non-ACI contexts, we allow the user to run the Restart command from the palette, and show stopped containers (however, in context menu, only the Start command is shown). However, for ACI contexts, this behavior is not mirrored. I think the fix is just to allow the "terminated" state in the multi-select regex for restartContainer.