Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--chmod support for COPY and ADD #2624

Closed
thernstig opened this issue Jan 13, 2021 · 8 comments · Fixed by #2649
Closed

--chmod support for COPY and ADD #2624

thernstig opened this issue Jan 13, 2021 · 8 comments · Fixed by #2649

Comments

@thernstig
Copy link
Contributor

In docker engine 20.10 support for the --chmod flag has been added. Trying to use it in a Dockerfile gives:

Unknown flag: chmoddockerfile-utils(40)

It would be nice to add support for it.

@bwateratmsft
Copy link
Collaborator

@thernstig I haven't been able to find any documentation about this flag, even in the release notes. Do you have any docs about it? Thanks!

@thernstig
Copy link
Contributor Author

thernstig commented Jan 13, 2021

See here moby/buildkit#1492 (comment). They just forgot to add it to the release notes.

@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Jan 13, 2021

Thanks!

Where are you seeing the above error? I did not get any intellisense for --chmod, but there was no error either.

I got the error to appear. @rcjsuen it seems this was a rather stealthy addition from Docker; can you add support for it in the language server?

@bwateratmsft bwateratmsft added this to the 1.10.0 milestone Jan 13, 2021
@rcjsuen
Copy link
Contributor

rcjsuen commented Jan 14, 2021

@rcjsuen it seems this was a rather stealthy addition from Docker; can you add support for it in the language server?

Yeah. There are a few different pieces to supporting a new flag but I'll start by making sure it is ignored by the linting process.

@rcjsuen
Copy link
Contributor

rcjsuen commented Jan 20, 2021

@bwateratmsft I've published version 0.3.0 of the language server to stop flagging the --chmod flag as an error for both ADD and COPY instructions.

@bwateratmsft
Copy link
Collaborator

Awesome! Thanks @rcjsuen!

@rcjsuen
Copy link
Contributor

rcjsuen commented Jan 20, 2021

@bwateratmsft Thanks for getting the fix merged in and thank you @thernstig for letting me know about this issue!

@bwateratmsft
Copy link
Collaborator

This is now released in Docker extension version 1.10.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants