Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up as many of the icons we ship as possible and use ThemeIcons #2654

Closed
bwateratmsft opened this issue Jan 21, 2021 · 2 comments · Fixed by #2678
Closed

Clean up as many of the icons we ship as possible and use ThemeIcons #2654

bwateratmsft opened this issue Jan 21, 2021 · 2 comments · Fixed by #2678
Labels
engineering fix released
Milestone
1.10.0

Comments

@bwateratmsft
Copy link
Collaborator

VSCode has a huge array of icons available in their codicons offering. Much of what they have overlaps with icons we have. We already use their ThemeIcons extensively, but we should try removing as many of our icons as possible in favor of ThemeIcons.
@bwateratmsft
Copy link
Collaborator Author

This might end up being a forcing function for doing this work...

@bwateratmsft bwateratmsft mentioned this issue Jan 27, 2021
Merged
@bwateratmsft bwateratmsft added this to the 1.10.0 milestone Jan 27, 2021
@bwateratmsft
Copy link
Collaborator Author

This is now released in Docker extension version 1.10.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
engineering fix released
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

Replace icons with Codicons wherever possible microsoft/vscode-docker
1 participant
@bwateratmsft