Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Display a "Use" button when hovering context #2719

Closed
csmarttemplates opened this issue Feb 10, 2021 · 4 comments · Fixed by #2784
Closed

Request: Display a "Use" button when hovering context #2719

csmarttemplates opened this issue Feb 10, 2021 · 4 comments · Fixed by #2784

Comments

@csmarttemplates
Copy link

Requiring a right click is clunky way to access the use action (and inspect for that matter).
It would be nicer if when you hover a context a "Use" button would be displayed the same way as the Pencil icon is shown to the right of the text label when you hover a breakpoint in the debug view.

Screen Shot 2021-02-10 at 12 40 20 PM

Would be nicer if there was an icon like the pencil below. It would save a click!

Screen Shot 2021-02-10 at 12 39 38 PM

@bwateratmsft
Copy link
Collaborator

I think this would be possible using a view item icon, which is what is present there in the breakpoints list.

@csmarttemplates we would need to use an icon from VSCode's Codicons list. From there I was thinking maybe "play", "debug-start", or "check", but I'm definitely open to other ideas. Can you check out that icon list and see if any seem like a good fit to you?

@csmarttemplates
Copy link
Author

I think I like "check" the most. "play" and "debug-start" are good but might be a little confusing since it implies something is being started rather than selected.

@dbreshears dbreshears added this to the 1.12.0 milestone Feb 17, 2021
@dbreshears dbreshears added the P3 label Feb 17, 2021
@ucheNkadiCode
Copy link
Contributor

ucheNkadiCode commented Feb 17, 2021

@bwateratmsft, let me know if these details are clear enough and if you agree with the icon selection.

Implementation details:

  • On Hover: Display an icon (likely the check icon from vscodicons) the user can click to use that context.
  • If the context is already being used, check icon will not be displayed.
  • Socket Icon will continue to constantly display context is currently in use regardless of on hover
  • Maintain functionality to right click and either select inspect or use.

@bwateratmsft
Copy link
Collaborator

This change is now released with Docker extension version 1.12.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants