Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of new Compose language ID #2761

Closed
3 tasks done
bwateratmsft opened this issue Mar 9, 2021 · 2 comments · Fixed by #2787
Closed
3 tasks done

Make use of new Compose language ID #2761

bwateratmsft opened this issue Mar 9, 2021 · 2 comments · Fixed by #2787
Labels
enhancement fix released
Milestone
1.12.0

Comments

@bwateratmsft
Copy link
Collaborator

bwateratmsft commented Mar 9, 2021 •
edited
Loading

Part of #2539.

VSCode recently added a language ID for Compose. More info here. We should make the following changes to support it:

  • Set minimum VS Code version to 1.55.0
  • Use onLanguage:dockercompose to target extension activations, rather than onLanguage:yaml
  • Use the "when": "resourceLangId == dockercompose" etc. to target commands

If possible, use the language ID to target the file picker? Not possible 😞
@bwateratmsft bwateratmsft added this to the 1.12.0 milestone Mar 9, 2021
@bwateratmsft bwateratmsft mentioned this issue Mar 16, 2021
Merged
@bwateratmsft bwateratmsft self-assigned this Mar 18, 2021
@bwateratmsft
Copy link
Collaborator Author

bwateratmsft commented Mar 29, 2021 •
edited
Loading

This may be postponed due to the timing of release.

Nope, it's out! https://code.visualstudio.com/updates/v1_55#_docker-compose-language

@bwateratmsft bwateratmsft removed their assignment Mar 31, 2021
@bwateratmsft
Copy link
Collaborator Author

bwateratmsft commented Apr 12, 2021 •
edited
Loading

This change is now released with Docker extension version 1.12.0.

@vscodebot vscodebot bot locked and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement fix released
Projects
None yet
Milestone
1.12.0
Development

Successfully merging a pull request may close this issue.

Make use of new Compose language ID microsoft/vscode-docker
1 participant
@bwateratmsft