Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixTypes requires meta.docs.url? #1955

Open
joshkel opened this issue Nov 26, 2024 · 1 comment
Open

fixTypes requires meta.docs.url? #1955

joshkel opened this issue Nov 26, 2024 · 1 comment
Labels
feature-request Request for new features or functionality
Milestone

Comments

@joshkel
Copy link

joshkel commented Nov 26, 2024

While looking into #1938, I added fixTypes to my VS Code settings.json:

  "eslint.options": {
    "fixTypes": ["problem", "suggestion", "layout"]
  },

However, I realized that that broke the ability to apply auto fixes within VS Code for my eslint-plugin-header rules.

It appears that this is because eslint-plugin-header's meta doesn't specify a docs.url, and vscode-eslint only stores rule information for rules that have docs.url:

https://github.com/microsoft/vscode-eslint/blob/release/3.0.10/server/src/eslint.ts#L162

Is this behavior necessary / correct?

@dbaeumer
Copy link
Member

I think that can be relaxed. I guess that when that code got added we only used it for the URLs

@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Nov 27, 2024
@dbaeumer dbaeumer added this to the Next milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants