Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting silently fails when required plugin is missing #242

Open
n4nn31355 opened this issue Oct 26, 2023 · 2 comments
Open

Linting silently fails when required plugin is missing #242

n4nn31355 opened this issue Oct 26, 2023 · 2 comments
Labels
bug Issue identified by VS Code Team member as probable bug needs PR

Comments

@n4nn31355
Copy link

Expectations:

  • code linting works
  • we have a distinct error message if required plugin is not installed

Actual behavior:

  • vscode-flake8 silently fails linting when flake8 is missing a plugin specified in require-plugins
  • no linting
  • no errors

Flake8 config:

[flake8]
require-plugins =
  flake8-bugbear
  non-existent-plugin

vscode-flake8 output:

2023-10-26 18:39:52.809 [info] file:///***.py :
There was a critical error during execution of Flake8:
required plugins were not installed!
- installed: flake8, flake8-bugbear, mccabe, pycodestyle, pyflakes
- expected: flake8-bugbear, non-existent-plugin
- missing: non-existent-plugin

Manual flake8 execution:

$ flake8; echo -e  "\nExit code: $?"
There was a critical error during execution of Flake8:
required plugins were not installed!
- installed: flake8, flake8-bugbear, mccabe, pycodestyle, pyflakes
- expected: flake8-bugbear, non-existent-plugin
- missing: non-existent-plugin

Exit code: 1

Versions:

vscode = 1.83.1
vscode-flake8  = v2023.8.0
flake8 = 6.1.0
python = 3.10.13
@karthiknadig
Copy link
Member

There is flake8.showNotification that can be set to error. The plan for the future is to show a error in the problems view when things like this happen.

@karthiknadig karthiknadig removed their assignment Oct 26, 2023
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug needs PR and removed triage-needed labels Oct 26, 2023
@n4nn31355
Copy link
Author

Yep. I have flake8.showNotification set to warning. But as you can see in vscode-flake8 output, somehow it's considered [info]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug needs PR
Projects
None yet
Development

No branches or pull requests

2 participants