Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme generator: colors for light theme should be used #77

Closed
aeschli opened this issue May 26, 2017 · 2 comments
Closed

Theme generator: colors for light theme should be used #77

aeschli opened this issue May 26, 2017 · 2 comments
Assignees
@aeschli
Labels
feature-request Request for new features or functionality

Comments

@aeschli
Copy link
Contributor

aeschli commented May 26, 2017

From @bpasero on April 26, 2017 13:56

Testing microsoft/vscode#25341

I created a light theme from the generator and gave it a try, but the result is quite ugly:

image

If the theme should really be "fresh", then maybe no workbench color should be filled in? Or some colors, but the same we use for light, dark or hc theme?

Copied from original issue: microsoft/vscode#25433
@aeschli
Copy link
Contributor Author

aeschli commented May 26, 2017

From @bpasero on April 26, 2017 14:3

Also weird in dark theme:

image

@aeschli aeschli self-assigned this May 26, 2017
@aeschli aeschli added feature-request Request for new features or functionality themes labels May 26, 2017
@aeschli
Copy link
Contributor Author

aeschli commented May 26, 2017

From @chrmarti on April 26, 2017 20:41

I guess this is the same, the sidebar is dark after choosing the light base theme:
image

@aeschli aeschli mentioned this issue May 26, 2017
Closed
@aeschli aeschli closed this as completed in db34994 Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeschli aeschli

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aeschli