Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

goimpl support #822

Closed
itsjamie opened this issue Feb 27, 2017 · 2 comments
Closed

goimpl support #822

itsjamie opened this issue Feb 27, 2017 · 2 comments

Comments

@itsjamie
Copy link
Contributor

Was looking at implementing goimpl support into VSCode. It was one aspect from vim-go that I miss.

Any objections to a PR for this?

Any tips for implementation? I was thinking I would use the gotests implementation as a guide.
@ramya-rao-a
Copy link
Contributor

#259 is tracking the feature request to integrate https://github.com/josharian/impl

I personally am not aware of pros and cons between using https://github.com/josharian/impl and https://github.com/sasha-s/goimpl
If you can make a comparison and present a case here, we have no objections for a subsequent PR and it is very much welcome :)

@mattetti
Copy link
Contributor

mattetti commented Mar 1, 2017

agreed, can we continue the conversation in #259 and close this duplicate issue tho?

@itsjamie itsjamie closed this as completed Mar 1, 2017
@itsjamie itsjamie mentioned this issue Mar 1, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattetti @itsjamie @ramya-rao-a