Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.0 Endgame #201

Closed
13 tasks done
yaohaizh opened this issue Dec 19, 2017 · 12 comments
Closed
13 tasks done

0.5.0 Endgame #201

yaohaizh opened this issue Dec 19, 2017 · 12 comments

Comments

@yaohaizh
Copy link
Contributor

yaohaizh commented Dec 19, 2017

Build

Test

Release

  • 12/20 - Add 0.5.0 tag for vscode-java-debug and java-debug - @andxu
  • 12/20 - Release to marketplace - @andxu

Notes

Before you check an item, please reply to this issue with the following details:

  1. What are the steps and details of your check?
  2. What are the configurations?
  3. What are the issues found in the process?
  4. What's your conclusion?
@testforstephen
Copy link
Contributor

testforstephen commented Dec 20, 2017

Windows 10

jdk: 1.8.0_151
vscode: 1.19.0

test evaluation

  1. Use vscode to open project https://github.com/vscjavaci/java-debug-ci/tree/master/testcase/4.variable
  2. launch debugger, if no projectName specified in launch.json, evaluation doesn't work. But if configured, watch multiple variables and step the program, the watch view will refresh automatically.
  3. Input expression x+=10 and str.toCharArray() at debug console view, the evaluation works.

open issues: #205, #206 (enhancement)

@testforstephen
Copy link
Contributor

Test generic Java 8 support on windows

jdk: 1.8.0_151
vscode: 1.19.0

  1. Use vscode to open project https://github.com/vscjavaci/java-debug-ci/tree/master/testcase/5.breakpoint
  2. Add breakpoint at line 13/30/38, start debugger.
  3. The breakpoints all can be hitted.
  4. Verify step/continue/restart/stop/source look up work.

@testforstephen
Copy link
Contributor

Test generic Java 9 support on windows

jdk: 9.0.1
vscode: 1.9.0

  1. Use vscode to open project https://github.com/vscjavaci/java-debug-ci/tree/master/testcase/19.java9-app
  2. Click F5, the debugger will resolve main class and generate launch.json.
  3. Add breakpoint at App.java, step/continue works.
  4. Add stepFilters to filter JDK, and relaunch debugger, step into line 11, it will skip the jdk classloader and stringbuilder class, and enter into the GSON.fromGson method directly.

@andxu
Copy link
Contributor

andxu commented Dec 20, 2017

Bug on no source test.

jdk: Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode)
vscode: 1.19.0
Evaluation doesn't work on generated lamda

1211888640 [in [Working copy] NoSourceTest.java [in [in src/main/java [in 8.nosource]]]] does not exist

@andxu
Copy link
Contributor

andxu commented Dec 20, 2017

Test breakpoint on Mac

jdk: Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode)
vscode: 1.19.0

  1. Open project https://github.com/vscjavaci/java-debug-ci/tree/master/testcase/5.breakpoint
  2. Set BP on println statements
  3. Add evaluation:
    new A().getClass().getName() and new A().getClass().getName()
  4. F5 until program ends.
  5. The breakpoint is hit on expected sequence and the evaluation result is correct.

@andxu
Copy link
Contributor

andxu commented Dec 20, 2017

Test variable on Mac

jdk: Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode)
vscode: 1.19.0

  1. Open project https://github.com/vscjavaci/java-debug-ci/tree/master/testcase/4.variable
  2. Set BP on the end statement of test
  3. Add evaluation:
    test() and str.charAt(0)
  4. F5 and modify the first char value on str when breakpoint is hit

@andxu
Copy link
Contributor

andxu commented Dec 20, 2017

Test thread on Mac

jdk: Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode)
vscode: 1.19.0

  1. Open project https://github.com/vscjavaci/java-debug-ci/tree/master/testcase/3.thread
  2. Set BP on the println statments
  3. Add evaluation:
    1+2
  4. keep on press F5
  5. the thread is started/break correctly and the expression is updated accordingly.

@yaohaizh
Copy link
Contributor Author

Test step filters

JDK: 9.0.1
VSCode 1.19.0
OS: Ubuntu 16.04

  1. Open project 19.java9-app in vscode
  2. F5 generate and set breakpoint
  3. Without step filter, it will step into ClassLoader.class file
  4. Setup the step filters by the default settings and restart debugging. This time, the ClassLoader.class is not show again in the step into.

@yaohaizh
Copy link
Contributor Author

Ubuntu

  • OS: Ubuntu 16.04
  • VSCode: 1.19.0

Java 8:

  • Following the steps from here: Test Plan vscjavaci/java-debug-ci#17
  • The basic functions work as expected: Breakpoints/threads/callstack/variable
  • Maven: Newly generated & spring-petclinic works correctly with debugging features.
  • Gradle & Single file: Press F5 without issues.

Java 9:

  • Following the steps from here: Test Plan vscjavaci/java-debug-ci#17
  • The basic functions work as expected: Breakpoints/threads/callstack/variable
  • Maven: Newly generated works correctly with debugging features.(Spring not supported on Java 9 yet)
  • Single file: Press F5 without issues.

@ansyral
Copy link
Contributor

ansyral commented Dec 20, 2017

VSCode insider

JDK: 9.0.1
OS: windows10

  1. Use vscode to open project https://github.com/vscjavaci/java-debug-ci/tree/master/testcase/19.java9-app

  2. set breakpoint and press F5

  3. add expression in watch panel, check evaluation.

@bsaby
Copy link
Contributor

bsaby commented Dec 20, 2017

Run test plan

Win10 x64 Win10 x86 Win10 x64 Mac Mac Ubuntu
VSCode1.9.0 JDK1.8.0_152 VSCode1.19.0 JDK1.8.0_152 VSCode1.19.0 JDK9.0.1 VSCode1.19.0 JDK1.8.0_144 VSCode1.19.0 JDK9.0.1 VSCode1.19.0 JDK9.0.1
  1. Following the steps from here: Test Plan vscjavaci/java-debug-ci#17
  2. Open single file evaluation bug: Single file: can not watch the variable value #204
  3. Test result:
Test case Win10 x64 Win10 x86 Win10 x64 Mac Mac Ubuntu
Configurations VSCode1.9.0 JDK1.8.0_152 VSCode1.19.0 JDK1.8.0_152 VSCode1.19.0 JDK9.0.1 VSCode1.19.0 JDK1.8.0_144 VSCode1.19.0 JDK9.0.1 VSCode1.19.0 JDK9.0.1
Clean install pass pass pass pass pass pass
Uninstall pass pass pass pass pass pass
Update pass pass pass pass pass pass
Auto generating launch.json pass pass #125 pass #125 #125
HelloWorld #204 #204 #204 #204 #204 #204
CallStack pass pass pass pass pass pass
Multiple Thread pass pass pass pass pass pass
Variables pass pass pass pass pass pass
Big stack frame pass pass pass pass pass pass
Breakpoint and inner class pass pass pass pass pass pass
Variable performance test pass pass pass pass pass pass
No debug information test pass pass pass pass pass pass
Attach evaluation pass pass pass pass pass pass
Maven test pass pass pass pass pass pass
Gradle test pass pass pass pass pass pass
PetClinc pass pass Not support jdk9 pass Not support jdk9 Not support jdk9
TODO application pass pass pass pass pass pass
Single file build pass pass #125 pass #125 #125
Console application #208 #208 #208 #208 #208 #208
Java 9 \ \ pass \ pass pass
Multi-root pass pass pass pass #125 #125
Step filters pass pass pass pass pass pass

@akaroml
Copy link
Member

akaroml commented Dec 20, 2017

Tested on Windows using spring-petclinic:

  1. Successfully launched programs using integrated terminal, internal console
  2. Successfully evaluated expression "this.hashCode() * 100"
  3. Inspected panels: VARIABLES, WATCH, CALL STACK, DEBUG CONSOLE
  4. Failed to launch using external terminal [Windows]Unable to launch in external terminal #210
  5. Failed to launch multiple programs using integrated terminal Cannot launch multiple programs in integrated terminal #209

Also tested on Mac using spring-petclinic:
All working plus able to launch using external terminal.

Conclusion, there are bugs but no blocking ones.

@andxu andxu closed this as completed Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants