Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End game 0.7.0 #250

Closed
13 tasks done
andxu opened this issue Mar 14, 2018 · 7 comments
Closed
13 tasks done

End game 0.7.0 #250

andxu opened this issue Mar 14, 2018 · 7 comments

Comments

@andxu
Copy link
Contributor

andxu commented Mar 14, 2018

Build

Test

Release

  • 3/15- Add 0.7.0 tag for vscode-java-debug and java-debug - @andxu
  • 3/15 - Release to marketplace - @andxu

Notes

Before you check an item, please reply to this issue with the following details:

  1. What are the steps and details of your check?
  2. What are the configurations?
  3. What are the issues found in the process?
  4. What's your conclusion?
@andxu
Copy link
Contributor Author

andxu commented Mar 15, 2018

Reproduce a known issue on Ubuntu:
image

@andxu
Copy link
Contributor Author

andxu commented Mar 15, 2018

I have tested conditional breakpoints on windows and ubuntu 16 lts, vscode and insider, and common java 8 && 9 features on Windows.

@testforstephen
Copy link
Contributor

Java 9 on Mac

  1. Open project 5.breakpoint in vscode.
  2. F5 and the launch.json is generated successfully.
  3. Click F5 to start debugging.
  4. Add breakpoint at inner class, anonymous class, they all can be hit.
  5. Try to set variable and evaluate, it works.
  6. Add a Conditional breakpoint at a for loop, the breakpoint is only hit when expression is satisfied.

@yaohaizh
Copy link
Contributor

Test Single file support with Conditional BP

  • Open single file from the java-debug-ci project
  • Set breakpoint with condition with two sites:
    • The first one is valid variable
    • The second one is invalid variable
  • Hit F5 to start debug
  • The breakpoint is hit in error condition
  • The condidtional works as expected in valid expression

@yaohaizh
Copy link
Contributor

yaohaizh commented Mar 15, 2018

Ubuntu

  • OS: Ubuntu 16.04
  • VSCode: 1.19.0

Java 8:

  • Following the steps from here: Test Plan vscjavaci/java-debug-ci#17
  • The basic functions work as expected: Breakpoints/threads/callstack/variable
  • Maven: Newly generated & spring-petclinic works correctly with debugging features.
  • Gradle & Single file: Press F5 without issues.

Java 9:

  • Following the steps from here: Test Plan vscjavaci/java-debug-ci#17
  • The basic functions work as expected: Breakpoints/threads/callstack/variable
  • Maven: Newly generated works correctly with debugging features.(Spring not supported on Java 9 yet)
  • Single file: Press F5 without issues.

@bsaby
Copy link
Contributor

bsaby commented Mar 15, 2018

Run test plan

  1. Configuration
Win10 x64 Win10 x86 Win10 x64 Mac Mac Ubuntu
Vscode 1.21.1 JDK 1.8.0_161 Vscode 1.21.1 JDK 1.8.0_161 Vscode 1.21.1 jdk-9.0.4 Vscode 1.21.1 JDK 1.8.0_151 Vscode 1.21.1 jdk-9.0.4 Vscode 1.21.1 JDK 1.8.0_131
  1. Open Bugs:
    Conditional breakpoint: com.sun.jdi.InvalidStackFrameException occurred while retrieving value #254 Still need project name for one project when attach debug  #255

  2. Test result

Test case Win10 x64 Win10 x86 Win10 x64 Mac Mac Ubuntu
Configurations Vscode 1.21.1 JDK 1.8.0_161 Vscode 1.21.1 JDK 1.8.0_161 Vscode 1.21.1 jdk-9.0.4 Vscode 1.21.1 JDK 1.8.0_151 Vscode 1.21.1 jdk-9.0.4 Vscode 1.21.1 JDK 1.8.0_131
Clean install Pass Pass Pass Pass Pass Pass
Uninstall Pass Pass Pass Pass Pass Pass
Update Pass Pass Pass Pass Pass Pass
Auto generating launch.json Pass Pass Pass Pass Pass Pass
HelloWorld Pass Pass Pass Pass Pass Pass
CallStack Pass Pass Pass Pass Pass Pass
Multiple Thread Pass Pass Pass Pass Pass Pass
Variables Pass Pass Pass Pass Pass Pass
Big stack frame Pass Pass Pass Pass Pass Pass
Breakpoint and inner class Pass Pass Pass Pass Pass Pass
No debug information test Pass Pass Pass Pass Pass Pass
Attach evaluation #255 #255 #255 #255 #255 #255
Gradle test Pass Pass Pass Pass Pass Pass
PetClinc Pass Pass \ Pass \ Pass
TODO application Pass pass pass Pass Pass Pass
Single file build Pass pass Pass Pass Pass Pass
Console application Pass pass pass Pass Pass Pass
Java 9 modular application \ \ Pass \ Pass \
Multi-root Pass Pass Pass Pass Pass Pass
Step filters Pass Pass pass Pass Pass Pass
Hot Code Replace Pass pass Pass Pass Pass Pass
Conditional Breakpoints[New] #254 pass pass #254 Pass #254

@andxu andxu closed this as completed Mar 15, 2018
@akaroml
Copy link
Member

akaroml commented Mar 15, 2018

Perfect. Thank you, everyone.

@akaroml akaroml added the eng label Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants