Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second pwa-node launch doesn't connect debugger #269

Closed
alexr00 opened this issue Jan 28, 2020 · 4 comments
Closed

Second pwa-node launch doesn't connect debugger #269

alexr00 opened this issue Jan 28, 2020 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Jan 28, 2020

Found testing microsoft/vscode#89393 on Windows

  • Add the pwa prefix to the Launch VS Code (Main Process) configuration in the vscode project
  • Run the Launch VS Code (Main Process) launch config.
  • Wait until debugging is ready
  • Close the OSS window that has opened
  • Debugging ends
  • Run the Launch VS Code (Main Process) again.
    Expected: The OSS window opens and debugging starts.
    Actual: The OSS window opens, but debugging never starts (no orange status bar + debug toolbar). When I close the OSS window, I get an error notification "no debug adapter found".
@alexr00
Copy link
Member Author

alexr00 commented Jan 28, 2020

Actually, the "no debug adapter found" shows when I close the OSS window the first time I try the launch config too.

@alexr00 alexr00 transferred this issue from microsoft/vscode Jan 28, 2020
@connor4312 connor4312 added this to the February 2020 milestone Feb 3, 2020
@connor4312 connor4312 modified the milestones: February 2020, March 2020 Mar 2, 2020
@connor4312
Copy link
Member

Does this still happen on recent insiders? Wonder if it's that session creation race; that was the cause of quite a few similar bugs.

@connor4312 connor4312 added the info-needed Issue requires more information from poster label Mar 10, 2020
@alexr00
Copy link
Member Author

alexr00 commented Mar 11, 2020

Looks like it's fixed now.

@connor4312
Copy link
Member

Cool, thanks for confirming!

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug verified Verification succeeded and removed info-needed Issue requires more information from poster labels Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants