Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Python is missing server auto starter tries to run and pops up the "Needs Python Extension" modal #10615

Closed
Tracked by #10749
joyceerhl opened this issue Jun 28, 2022 · 2 comments · Fixed by #10851
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-getting-started verified Verification succeeded
Milestone

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Jun 28, 2022

Testing #10590

For step 7 in the Install Python Extension command scenario, i.e.

Uninstall the Python extension to clear the kernel that was found (might need to reload the window here as we cache the controllers that we find). This time, instead of clicking the run button click on the command directly and run the command from the kernel picker menu.

Uninstalling the Python extension also uninstalls the Jupyter extension. This is because of the extension pack relationship--all extensions that are part of an extension pack are uninstalled when the extension pack itself is uninstalled.

Additionally, after uninstalling the Python extension I'm prompted to reload the window as mentioned in the TPI. After the reload, presumably because a notebook is open already, I get this:
image

If we're already recommending the Python extension this strongly (having a kernel command to install the Python extension), could we also update this dialog in the screenshot above to include an Install button which will directly install the Python extension?

@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 28, 2022
@IanMatthewHuff
Copy link
Member

@joyceerhl Sorry I should have specified this better in the steps. You can get just Jupyter if you install Jupyter by itself first. You can't start with the Python extension though, as noted due to the pack issue.

That scenario where you see the "Python extension is required to perform that task" is actually happening since your vscode is not in a clean state. That's the Jupyter autostarter trying to start a customer kernel, and it only does that when you've successfully already started a kernel recently. I think that it's still worth fixing, but it will be a bit lower priority as a new user won't see that (as they will not have a successful start already). I think we should just change the autostart scenario to never show UI though regardless of what happens.

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug iteration-candidate and removed triage-needed Issue needs to be triaged labels Jun 30, 2022
@IanMatthewHuff IanMatthewHuff changed the title Uninstalling Python extension also uninstalls Jupyter extension If Python is missing server auto starter tries to run and pops up the "Needs Python Extension" modal Jul 5, 2022
@greazer greazer added this to the July 2022 milestone Jul 6, 2022
@IanMatthewHuff
Copy link
Member

Hmm, actually was our interpreter package checking for telemetry causing this.

Validation steps.

Install Jupyter extension (install this first so you don't get the Python + Jupyter pack)
Install Python extension
Run a notebook with a kernel found by the python extension
Uninstall Python extension
Reload

Previous you'd get a prompt to install the Python Extension. Prompt should be gone now.

@connor4312 connor4312 added the verified Verification succeeded label Jul 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-getting-started verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants