Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh button not updating for deleted kernels #12232

Closed
roblourens opened this issue Nov 30, 2022 · 4 comments · Fixed by #12554
Closed

Refresh button not updating for deleted kernels #12232

roblourens opened this issue Nov 30, 2022 · 4 comments · Fixed by #12554
Assignees
@DonJayamanne
Labels
bug Issue identified by VS Code Team member as probable bug notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) notebook-kernel-picker verified Verification succeeded
Milestone
January 2023

Comments

@roblourens
Copy link
Member

Testing #11963

If the kernel picker can update while it's open, is the refresh button still needed?
@DonJayamanne
Copy link
Contributor

Yes, e.g if you delete/create a conda or virtual env outside vscode, then it might not necessarily appear here.
after all we rely on file monitoring and thats not guaranteed to work 100% of the time

At that point refresh is the only way to get things updated.

@roblourens
Copy link
Member Author

roblourens commented Nov 30, 2022 •
edited
Loading

When I delete a venv via the terminal, then click refresh, it's actually still there

I close and reopen the kernel picker, then it appears

@roblourens roblourens reopened this Nov 30, 2022
@roblourens roblourens changed the title Refresh button needed? Refresh button not updating for deleted kernels Nov 30, 2022
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug kernel-picker labels Dec 2, 2022
@DonJayamanne DonJayamanne added this to the December 2022 milestone Dec 2, 2022
@DonJayamanne
Copy link
Contributor

I close and reopen the kernel picker, then it appears

@roblourens didn't you mean then it disappears

@rebornix rebornix added notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) notebook-kernel-picker and removed kernel-picker labels Dec 9, 2022
@roblourens
Copy link
Member Author

I guess so, I don't quite remember what I was seeing sorry

@DonJayamanne DonJayamanne mentioned this issue Jan 17, 2023
Merged
@roblourens roblourens added the verified Verification succeeded label Jan 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
bug Issue identified by VS Code Team member as probable bug notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) notebook-kernel-picker verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Update kernel picker when a Python env is deleted microsoft/vscode-jupyter
3 participants
@roblourens @rebornix @DonJayamanne