Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional detail for remote kernels in kernel picker looks weird #12344

Closed
rebornix opened this issue Dec 7, 2022 · 6 comments · Fixed by #12589
Closed

Optional detail for remote kernels in kernel picker looks weird #12344

rebornix opened this issue Dec 7, 2022 · 6 comments · Fixed by #12589
Assignees
@DonJayamanne
Labels
bug Issue identified by VS Code Team member as probable bug notebook-kernel-picker verified Verification succeeded
Milestone
January 2023

Comments

@rebornix
Copy link
Member

rebornix commented Dec 7, 2022

image

It looks weird that we are showing detail for remote kernels but not others.
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook-kernel-picker labels Dec 7, 2022
@rebornix rebornix added this to the December 2022 milestone Dec 7, 2022
@DonJayamanne
Copy link
Contributor

Agreed. the argument here was that when dealing with remote active kernels the last time it was active is crucial in picking a kernel.
However we could easily just remove this and see whether users complain.
I think this was based on an assumption that it was required

@rebornix rebornix added the mru label Dec 9, 2022
@rebornix
Copy link
Member Author

We can probably change this
image

to

image

@DonJayamanne DonJayamanne mentioned this issue Jan 19, 2023
Closed
54 tasks
@DonJayamanne
Copy link
Contributor

In controller do not display detail controllers within the Jupyter extension.

@DonJayamanne DonJayamanne mentioned this issue Jan 19, 2023
Merged
@andreamah
Copy link

Is there an easy way to get a remote kernel so that we can verify this?

@rebornix
Copy link
Member Author

@andreamah if you have Docker installed you can use https://marketplace.visualstudio.com/items?itemName=rebornix.vscode-jupyter-docker-stack-connect

@rebornix
Copy link
Member Author

I can actually verify this.

@rebornix rebornix removed their assignment Jan 27, 2023
@rebornix rebornix added the verified Verification succeeded label Jan 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
bug Issue identified by VS Code Team member as probable bug notebook-kernel-picker verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

No details for controllers in kernel picker microsoft/vscode-jupyter
3 participants
@rebornix @DonJayamanne @andreamah