Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store isInteractiveWindowMessageCell in metadata instead of custom metadata #15378

Closed
Tracked by #205637
DonJayamanne opened this issue Mar 18, 2024 · 0 comments · Fixed by #15381
Closed
Tracked by #205637

Store isInteractiveWindowMessageCell in metadata instead of custom metadata #15378

DonJayamanne opened this issue Mar 18, 2024 · 0 comments · Fixed by #15381
Assignees
@DonJayamanne
Labels
debt Code quality issues
Milestone
March 2024

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Mar 18, 2024 •
edited
Loading

We cannot store isInteractiveWindowMessageCell in mardown cell metadata in custom.
Given that Jupyter does not support metadata in markdown cells, we shnould not store this under custom
Instead it should jsut be at the root level, i.e. remove custom when storing isInteractiveWindowMessageCell

For microsoft/vscode#205637
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Mar 18, 2024
@DonJayamanne DonJayamanne self-assigned this Mar 18, 2024
@DonJayamanne DonJayamanne added this to the March 2024 milestone Mar 18, 2024
@DonJayamanne DonJayamanne mentioned this issue Mar 18, 2024
Closed
@DonJayamanne DonJayamanne changed the title Find an alternative to isInteractiveWindowMessageCell as Mardown cells cannot have metadata Store isInteractiveWindowMessageCell in metadata instead of custom metadata Mar 18, 2024
@DonJayamanne DonJayamanne mentioned this issue Mar 18, 2024
Merged
@DonJayamanne DonJayamanne added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Mar 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Code quality issues
Projects
None yet
Milestone
March 2024
Development

Successfully merging a pull request may close this issue.

Store isInteractiveWindowMessageCell at root level microsoft/vscode-jupyter
1 participant
@DonJayamanne