Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure cell metadata properties are sorted in the diff view (with custom metadata) #15410

Closed
2 of 4 tasks
DonJayamanne opened this issue Mar 20, 2024 · 0 comments
Closed
2 of 4 tasks

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Mar 20, 2024

Refs: microsoft/vscode#205634

Complexity: 2

Authors: @DonJayamanne

Create Issue


Setup

Steps

  • Create a notebook file
  • Add a cell and save it
  • Add a cell tag (use command Add Cell Tag)
  • Save the file
  • Go into time time view and verify the new tag is visible
  • Add a cell, then save that notebook and delete the cell and save the notebook again
  • Add a slide type (use command Switch Slide Type)
  • Save the notebook
  • Go into time line view and view the diffs
  • Verify the order of the metada in the diff view is slide and tags
  • And verify you do not see misalignment of the properties as per the screenshot here Timeline diffview for latest item is incorrect due to sorting of properties in metadata #15402

Things to verify

  • Properties in metadat are alphabetically sorted
  • the words custom does not appear in the diff view for metadata

Test again:

  • This time without the setting `"jupyter.experimental.dropCustomMetadata": true,``
  • At this point, the words custom will appear
@github-actions github-actions bot added this to the March 2024 milestone Mar 20, 2024
@DonJayamanne DonJayamanne changed the title Ensure cell metadata properties are sorted in the diff view Ensure cell metadata properties are sorted in the diff view (with custom metadata) Mar 20, 2024
@vscodenpa vscodenpa added the triage-needed Issue needs to be triaged label Mar 21, 2024
@microsoft microsoft deleted a comment from github-actions bot Mar 22, 2024
@amunger amunger removed their assignment Mar 25, 2024
@rebornix rebornix removed their assignment Mar 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants