Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install kernel/Change Kernel doesn't work in the interactive window #6082

Closed
Tracked by #6188
rchiodo opened this issue Jun 2, 2021 · 2 comments
Closed
Tracked by #6188

Install kernel/Change Kernel doesn't work in the interactive window #6082

rchiodo opened this issue Jun 2, 2021 · 2 comments
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Jun 2, 2021

Create a venv with no ipykernel

Send code to interactive window
image

Click change kernel

Dialog pops up a second time and you're not allowed to change a kernel.

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Jun 2, 2021
@greazer greazer added this to the June 2021 Release milestone Jun 3, 2021
@DonJayamanne DonJayamanne self-assigned this Jun 4, 2021
@DonJayamanne
Copy link
Contributor

This is blocked by #6135
I've added a work around that will disable changing of kernels.
Also we get a horrible UX, we get the modal dialog twice for Interactive (just again part of the current code flow, we didn't notice this earlier because they weren't modal dialogs).

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jun 4, 2021

I'm going to change this from a modal to non-modal for Interactive, as its a very poor UX. (reverting to the exiting UI, which results in two messageboxes, at least they are not modal)

@DonJayamanne DonJayamanne removed their assignment Jun 7, 2021
@rchiodo rchiodo added the verification-needed Verification of issue is requested label Jul 26, 2021
@rchiodo rchiodo closed this as completed Jul 26, 2021
@roblourens roblourens added the verified Verification succeeded label Jul 29, 2021
@DonJayamanne DonJayamanne removed the verification-needed Verification of issue is requested label Jul 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants