Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not fire onDidSendMessage for requests #7200

Closed
Tracked by #5607
roblourens opened this issue Aug 18, 2021 · 4 comments
Closed
Tracked by #5607

Should not fire onDidSendMessage for requests #7200

roblourens opened this issue Aug 18, 2021 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook-debugging verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

The debug adapter fires onDidSendMessage for requests that should be sent to the kernel.

This should only be fired for messages going to VS Code (events, responses, and requests handled by VS Code itself)

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug debt Code quality issues labels Aug 18, 2021
@greazer greazer added this to the August 2021 milestone Aug 19, 2021
@roblourens
Copy link
Member Author

Fixed in #7226

@DavidKutu DavidKutu added the verification-needed Verification of issue is requested label Aug 26, 2021
@rzhao271
Copy link
Contributor

@roblourens what are some verification steps for this change?

@DavidKutu
Copy link

DavidKutu commented Aug 26, 2021

There's an error message from VS Code that should show up on the Jupyter Output if we fire that for requests.

set this setting to get the debug messages:
"jupyter.logging.level": "verbose"

@sandy081 sandy081 removed the verification-needed Verification of issue is requested label Aug 27, 2021
@sandy081
Copy link
Member

Removing verification-needed label because it isa bug and it is included by default in verification list

@rzhao271 rzhao271 added the verified Verification succeeded label Aug 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook-debugging verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants