Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the tooltip defined to run the next line when doing Run By Line #7453

Closed
thegunslingers opened this issue Sep 8, 2021 · 5 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook-run-by-line verified Verification succeeded
Milestone

Comments

@thegunslingers
Copy link

Did search and I believe this is not a duplicate issue.

Environment data

  • VS Code version: 1.60
  • Jupyter Extension version (available under the Extensions sidebar): v2021.8.2031190714
  • Python Extension version (available under the Extensions sidebar): v2021.9.1191016588
  • OS (Windows | Mac | Linux distro) and version: Win 10
  • Python and/or Anaconda version: Python 3.9
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
  • Jupyter server running: Local

Expected behavior

Expected Behavior 1. After Clicking Run By Line the Continue button shows F5 as F5 is a the hotkey to continue
Expected Behavior 2. Clicking the 'Continue button' will continue to execute code until the next break-point.

Actual behavior

Actual Behavior 1. After Clicking Run By Line the Continue button shows F10. F10 steps to the next line like with the normal VScode debugger.
Actual Behavior 2. Clicking the 'Continue button' performs a step over/next (rather than continue)

vscode_jupyter_debug

Steps to reproduce:

  1. Open a juypter notebook in VSCode with the vscode-jupyter extension installed
  2. Put some python code in a cell
  3. Click run by line
  4. Hover over the continue button ( observer popup)
  5. Click the Continue button (observe a step over / next rather than a continue)

Logs

N/A

Additional Thoughts

It would be helpful to have buttons for Step, Next, Continue etc with the Juypter notebook (think I saw that the roadmap).
Please use the same hotkeys as the VScode debugger (F5 to start debugging (rather than F10), and then F5 continue, F10 next/step over, F11 step in, F11+shift step out.

Also just wanted to say thank you for adding convenient debugging for juypter notebooks! Not having easy (imo) debugging in juypter notebooks has been a big detractor of using juypter notebooks for me personally.

@thegunslingers thegunslingers added the bug Issue identified by VS Code Team member as probable bug label Sep 8, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Sep 8, 2021

Thanks for the suggestion. Full debugging is actually coming to jupyter notebooks too.

What you were using is called Run by line and is slightly different from full debugging (hence why continue is F10, it's the only option). Run by line is literally running one line at a time. You can't use F5 and you can't continue. After interviewing lots and lots of data scientists, run by line was deemed more digestable than full debugging so we did that first.

@rchiodo rchiodo added enhancement and removed bug Issue identified by VS Code Team member as probable bug labels Sep 8, 2021
@rchiodo rchiodo removed their assignment Sep 8, 2021
@rchiodo
Copy link
Contributor

rchiodo commented Sep 8, 2021

I do think 'Continue' is confusing. We should at least rename it to like 'run next line' or something similar.

@thegunslingers
Copy link
Author

That does make sense and I guess there is always an odd man out lol. I agree renaming could be a good solution. Also for what it's worth all the hot keys for full debuging do work after starting a debug session in the version i'm on. (Leave that it in please :) )

@greazer
Copy link
Member

greazer commented Sep 9, 2021

Renaming the tooltip makes sense here.

@greazer greazer added bug Issue identified by VS Code Team member as probable bug debt Code quality issues labels Sep 23, 2021
@greazer greazer modified the milestones: September 2021, October 2021 Sep 23, 2021
@greazer greazer self-assigned this Oct 7, 2021
@greazer
Copy link
Member

greazer commented Oct 8, 2021

This is already done. The tooltip now says: Run Next Line (F10)

@greazer greazer closed this as completed Oct 8, 2021
@greazer greazer changed the title Run By Line Issue Rename the tooltip defined to run the next line when doing Run By Line Oct 8, 2021
@greazer greazer added the verified Verification succeeded label Oct 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook-run-by-line verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants