Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run by line: no way to stop execution #7747

Closed
isidorn opened this issue Sep 29, 2021 · 3 comments
Closed

Run by line: no way to stop execution #7747

isidorn opened this issue Sep 29, 2021 · 3 comments

Comments

@isidorn
Copy link

isidorn commented Sep 29, 2021

Testing microsoft/vscode#133903

Should we have a stop button to stop execution?
Also continue execution does not respect breakpoints? Is this expected?

Bonus idea: the other actions in the toolbar do not make much sense while you are running, do they? Should we customise the toolbar a bit more while the user is running?

Screenshot 2021-09-29 at 17 44 38

@isidorn isidorn changed the title Run by line: no way to stop execution Continue Execution - very confusing name Sep 29, 2021
@isidorn isidorn changed the title Continue Execution - very confusing name Run by line: no way to stop execution Sep 29, 2021
@DavidKutu
Copy link

To stop execution we have the interrupt button on the left.

@DavidKutu DavidKutu transferred this issue from microsoft/vscode Sep 29, 2021
@isidorn
Copy link
Author

isidorn commented Sep 30, 2021

Ok, thanks for letting me know.
Feel free to close this then, however some feedback on the interrupt button:

  • Does not really look like a button or clickable
  • Due to square shape looks like a rendering glitch

Could we use some other icon here? Something more rich?

@DavidKutu
Copy link

Notebook users are used to the run/stop button.

I'll be down to reopen this with a title like Interrupt button does not look clickable, add the community feedback label and see if people agree.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants