Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Select a kernel' walkthrough step button does nothing #8800

Open
joyceerhl opened this issue Jan 25, 2022 · 5 comments
Open

'Select a kernel' walkthrough step button does nothing #8800

joyceerhl opened this issue Jan 25, 2022 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-getting-started

Comments

@joyceerhl
Copy link
Contributor

Testing #8793
Recording 2022-01-25 at 08 44 00

@minsa110 minsa110 added bug Issue identified by VS Code Team member as probable bug and removed needs-triage labels Jan 27, 2022
@minsa110 minsa110 removed their assignment Jan 27, 2022
@minsa110
Copy link
Contributor

Fixed per #8823

@minsa110 minsa110 added this to the January 2022 milestone Jan 27, 2022
@roblourens roblourens added verified Verification succeeded and removed verified Verification succeeded labels Jan 31, 2022
@roblourens
Copy link
Member

The command doesn't work when I run it from the command palette here since the focus is not in the notebook editor

@roblourens
Copy link
Member

roblourens commented Jan 31, 2022

I don't know if it's possible to do this with a button in the getting started page, since the command needs to run with the notebook focused. You probably just have to tell the user to click the Select Kernel button

@greazer greazer closed this as completed Jan 31, 2022
@roblourens roblourens reopened this Jan 31, 2022
@greazer greazer modified the milestones: January 2022, January 2022 Recovery Feb 3, 2022
@greazer greazer modified the milestones: January 2022 Recovery, February 2022 Feb 3, 2022
@greazer greazer closed this as completed Feb 24, 2022
@roblourens
Copy link
Member

There's still a button on that page that doesn't work.

@roblourens roblourens reopened this Feb 25, 2022
@roblourens roblourens added the verification-found Issue verification failed label Feb 25, 2022
@roblourens
Copy link
Member

roblourens commented Feb 25, 2022

We could probably have the command operate on whichever notebook editor is in the foreground (even if it's not focused). That sounds reasonable to me, tbh. I can look into that if you want to go that route.

@greazer greazer modified the milestones: February 2022, March 2022 Feb 28, 2022
@greazer greazer removed needs-triage verification-found Issue verification failed labels Feb 28, 2022
@rchiodo rchiodo modified the milestones: March 2022, April 2022 Mar 23, 2022
@rchiodo rchiodo modified the milestones: April 2022, May 2022 Apr 27, 2022
@rchiodo rchiodo removed this from the May 2022 milestone May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug notebook-getting-started
Projects
None yet
Development

No branches or pull requests

5 participants