-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reword ipykernel installation message #9159
Comments
We've had this discussion in the past. Backed by survey data. And we ended up with what we have today. Not sure what we could do to make it better for everyone. More Info maybe (then we have 4 buttons on that dialog). I think the 'blessed environment' solves this issue a better way. |
Here's the last discussion when we switched to a modal dialog: |
I agree with @rchiodo . Then again, I guess the suggestion for the change is because @greazer feels the current message is not clear yet again. But does this mean we'll stop re-visiting this message? I think we've changed this particular message more than 3 times already. Not that its a bad thing, but feel perhaps we're beating a dead horse and its possible its just complicated and we need to make it very simple (& i thought thats why we ended up with the message we have today). Also note: |
Seems that the wording message may not be necessary (other than possibly mentioning "jupyter dependency") but at least having a link to learn more about why it's needed would be good. |
Given the comments above I'm leaving the prompt wording as is. Given Jim's last comment I feel this is resolved by my work on #10658 with the more info prompt added and the wiki page on ipykernel. |
Even people who are familiar with Jupyter may not know why "ipykernel" needs to be installed sometimes. We had an internal case-in-point.
The message we show to the user should provide some level of explanation. Something like "Either the ipykernel or jupyter package needs to be installed in the current environment to support running cells in [interactive-window | jupyter notebooks]. Would you like us to install ipykernel for you?" (Learn more...)
Learn more could discuss the difference.
The text was updated successfully, but these errors were encountered: