Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword ipykernel installation message #9159

Closed
greazer opened this issue Feb 28, 2022 · 5 comments
Closed

Reword ipykernel installation message #9159

greazer opened this issue Feb 28, 2022 · 5 comments
Labels
bug Issue identified by VS Code Team member as probable bug notebook-getting-started verified Verification succeeded
Milestone

Comments

@greazer
Copy link
Member

greazer commented Feb 28, 2022

Even people who are familiar with Jupyter may not know why "ipykernel" needs to be installed sometimes. We had an internal case-in-point.

The message we show to the user should provide some level of explanation. Something like "Either the ipykernel or jupyter package needs to be installed in the current environment to support running cells in [interactive-window | jupyter notebooks]. Would you like us to install ipykernel for you?" (Learn more...)

Learn more could discuss the difference.

@greazer greazer added bug Issue identified by VS Code Team member as probable bug notebook-getting-started labels Feb 28, 2022
@greazer greazer added this to the March 2022 milestone Feb 28, 2022
@rchiodo rchiodo added discuss-at-standup and removed bug Issue identified by VS Code Team member as probable bug labels Mar 14, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Mar 14, 2022

We've had this discussion in the past. Backed by survey data. And we ended up with what we have today.

Not sure what we could do to make it better for everyone. More Info maybe (then we have 4 buttons on that dialog).

I think the 'blessed environment' solves this issue a better way.

@rchiodo
Copy link
Contributor

rchiodo commented Mar 14, 2022

Here's the last discussion when we switched to a modal dialog:

#5798

@DonJayamanne DonJayamanne self-assigned this Mar 15, 2022
@DonJayamanne
Copy link
Contributor

I agree with @rchiodo . Then again, I guess the suggestion for the change is because @greazer feels the current message is not clear yet again. But does this mean we'll stop re-visiting this message? I think we've changed this particular message more than 3 times already. Not that its a bad thing, but feel perhaps we're beating a dead horse and its possible its just complicated and we need to make it very simple (& i thought thats why we ended up with the message we have today).

Also note: ipykernel or jupyter isn't correct, as installing jupyter doesn't install ipykernel

@DonJayamanne DonJayamanne removed their assignment Mar 15, 2022
@greazer
Copy link
Member Author

greazer commented Mar 17, 2022

Seems that the wording message may not be necessary (other than possibly mentioning "jupyter dependency") but at least having a link to learn more about why it's needed would be good.

@greazer greazer added bug Issue identified by VS Code Team member as probable bug and removed discuss-at-standup labels Mar 17, 2022
@rchiodo rchiodo modified the milestones: March 2022, April 2022 Mar 23, 2022
@rchiodo rchiodo modified the milestones: April 2022, May 2022 Apr 27, 2022
@rchiodo rchiodo modified the milestones: May 2022, June 2022 Jun 1, 2022
@rchiodo rchiodo removed their assignment Jul 1, 2022
@rchiodo rchiodo modified the milestones: June 2022, July 2022 Jul 1, 2022
@IanMatthewHuff
Copy link
Member

Given the comments above I'm leaving the prompt wording as is. Given Jim's last comment I feel this is resolved by my work on #10658 with the more info prompt added and the wiki page on ipykernel.
https://github.com/microsoft/vscode-jupyter/wiki/Jupyter-Kernels-and-the-Jupyter-Extension

@connor4312 connor4312 added the verified Verification succeeded label Jul 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-getting-started verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants