Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing extensions to prototypes of base types in favor of custom functions #9607

Closed
karrtikr opened this issue Apr 6, 2022 · 2 comments
Closed

Consider removing extensions to prototypes of base types in favor of custom functions #9607

karrtikr opened this issue Apr 6, 2022 · 2 comments
Assignees
@DonJayamanne
Labels
debt Code quality issues good first issue Good for newcomers

Comments

@karrtikr
Copy link
Contributor

karrtikr commented Apr 6, 2022

See microsoft/vscode-python#18871.

We can either convert them to functions, or the rename the names so they're unique enough: microsoft/vscode-python#18870
@rchiodo rchiodo added the debt Code quality issues label Apr 6, 2022
@rchiodo rchiodo removed their assignment Apr 6, 2022
@DonJayamanne DonJayamanne changed the title Consider converting type definitions in extensions.ts to functions Consider removing extensions to prototypes of base types in favor of custom functions Apr 6, 2022
@DonJayamanne
Copy link
Contributor

I'm totally in favor of removing such magic.

@DonJayamanne DonJayamanne mentioned this issue Nov 15, 2022
Closed
This was referenced Feb 27, 2023
Merged
Merged
Merged
Merged
@DonJayamanne DonJayamanne self-assigned this Feb 27, 2023
@DonJayamanne
Copy link
Contributor

This has been completed

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Code quality issues good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DonJayamanne @greazer @karrtikr @rchiodo