Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow folding html tags with blank new lines #119

Open
mjbvz opened this issue Feb 28, 2023 · 1 comment
Open

Allow folding html tags with blank new lines #119

mjbvz opened this issue Feb 28, 2023 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 28, 2023

Tracks enabling folding of html in markdown such as:

<details>

Some text

</details>

This is currently not foldable because it is (correctly) tokenized to two html elements instead of a single html block

@sethp
Copy link

sethp commented Mar 1, 2023

This is currently not foldable because it is (correctly) tokenized to two html elements instead of a single html block

Oh, interesting: yeah, it looks like that tokenizer represents the structure with the help of the nesting and level attributes? I do see a single HTML node in the rendered DOM:

a screenshot of the dom with the paragraph element inside the details element

Although, this makes me a little suspicious of the token stream:

<details>

<details>

some text

</details>

</details>

does get rendered as I'd expect:

another dom screenshot with two nested details elements with a <p> tag inside

but I can't see a way from the tokens to determine that the second <details> is inside of the first <details> (they both have level/nesting 0).

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Dec 6, 2023
@mjbvz mjbvz added this to the Backlog milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants