Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear behavior when having two changes, one inside a comment and one outside #6165

Open
dbaeumer opened this issue Aug 27, 2024 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@dbaeumer
Copy link
Member

Testing #6160

I did two change, one inside a comment and one outside and then ran the action from the SCM viewlet. Here is what happend:

  • got the dialog.
  • the one inside the comment got converted but the diff didn't revert. I would have expected to see that happening since the suggestion got created.
  • the other diff stayed, which is IMO correct.
@alexr00
Copy link
Member

alexr00 commented Aug 27, 2024

I only show the option to revert the change if all the conversions succeeded. I'll add an option to revert even if not everything succeeded.

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Aug 27, 2024
@alexr00 alexr00 added this to the August 2024 milestone Aug 27, 2024
@alexr00
Copy link
Member

alexr00 commented Aug 28, 2024

Actually, I can only revert entire files, not just select changes. I think the current behavior is less confusing than only reverting the files for which ever suggestion conversion succeeded.

@alexr00 alexr00 modified the milestones: August 2024, Backlog Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants