Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto formatting (format as you type) removes spaces when it shouldn't #1505

Closed
DonJayamanne opened this issue Apr 26, 2018 · 2 comments · Fixed by #1508
Closed

Auto formatting (format as you type) removes spaces when it shouldn't #1505

DonJayamanne opened this issue Apr 26, 2018 · 2 comments · Fixed by #1508
Assignees
@MikhailArkhipov
Labels
area-formatting bug Issue identified by VS Code Team member as probable bug
Milestone
April 2018

Comments

@DonJayamanne
Copy link

a, b = function_returning_a_tuple()
Gets formatted to:
a, b=function_returning_a_tuple()
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR area-formatting labels Apr 26, 2018
@DonJayamanne DonJayamanne changed the title Auto formatting removes spaces Auto formatting (format as you type) removes spaces when it shouldn't Apr 26, 2018
@DonJayamanne
Copy link
Author

@brettcannon
Is this something that should be added to the grammar file (upstream). Surprised there is no example of unpacking tuples in there (I couldn't find one).
@MikhailArkhipov cc

@MikhailArkhipov MikhailArkhipov self-assigned this Apr 26, 2018
@MikhailArkhipov MikhailArkhipov added this to the April 2018 milestone Apr 26, 2018
@MikhailArkhipov
Copy link

It is one of the cases when looking at a single line it is hard to tell if this is argument list or not. We don't have real expression parser.

@MikhailArkhipov MikhailArkhipov mentioned this issue Apr 26, 2018
Merged
5 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MikhailArkhipov MikhailArkhipov

Labels
area-formatting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
April 2018
Development

Successfully merging a pull request may close this issue.

Improve detection of the function argument list in autoformat
3 participants
@brettcannon @DonJayamanne @MikhailArkhipov