Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow to load sys in list of modules #1773

Closed
DonJayamanne opened this issue May 29, 2018 · 8 comments
Closed

Slow to load sys in list of modules #1773

DonJayamanne opened this issue May 29, 2018 · 8 comments
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug

Comments

@DonJayamanne
Copy link

  • Install new analysis engine
  • Type import sy
  • The auto completion list does not have sys in the completion list
    screen shot 2018-05-29 at 22 18 49

There's a slight delay in getting this list.
Wait for a second or two, type once again, then it works.

However for someone starting out might get confused and consider this to be a bug or buggy (implementation).

@qubitron @MikhailArkhipov @brettcannon

I'm flagging this as a bug, as I believe that's what a newbie starting with this new analysis engine would assume it to be.

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs decision labels May 29, 2018
@MikhailArkhipov
Copy link

We need #1591

@brettcannon
Copy link
Member

Could we get a "Loading" notification like we do with Jedi until we have complete completions instead of a partial list?

@qubitron
Copy link

To clarify, we'd like to have the [Loading...] tooltip (not a notification banner)

@MikhailArkhipov
Copy link

#2099 adds progress report in the status bar. The Loading tooltip is controlled by VS Code and is displayed when async task for the completion list hasn't returned yet. In this case the list was provided - but it was not complete. In this case there is no 'loading' state.

@MikhailArkhipov MikhailArkhipov self-assigned this Jul 6, 2018
@qubitron
Copy link

qubitron commented Jul 6, 2018

So that I understand this correctly: will the list automatically update with the complete results if the user waits for the loading to complete? If so, then the status bar approach makes sense to me.

@MikhailArkhipov
Copy link

The list never auto-updates. There is no such facility in VS Code. It shows static data returned from the last call to the LS. There is no way to tell VSC to re-open or update the list. Only big VS can do this.

@MikhailArkhipov
Copy link

image

@DonJayamanne
Copy link
Author

Closing as we have addressed the concerns with the addition of the progress indicator.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

4 participants