Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Create Environment within the Select Interpreter quick pick #20249

Closed
brettcannon opened this issue Nov 18, 2022 · 8 comments
Closed
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality

Comments

@brettcannon
Copy link
Member

Would it be worth having a Create Environment with ... option in the environment quick pick that would use the newest version of Python found to be installed globally?

@brettcannon brettcannon added the feature-request Request for new features or functionality label Nov 18, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 18, 2022
@luabud
Copy link
Member

luabud commented Nov 18, 2022

Yeah I think it would be great :) but I'd vote to also let the user pick the global env if there's more than one available

@karrtikr
Copy link

We could do it as an icon as well which maybe more intuitive:

image

@eleanorjboyd eleanorjboyd removed the triage-needed Needs assignment to the proper sub-team label Nov 21, 2022
@brettcannon
Copy link
Member Author

But how discoverable is that icon? I personally would never think to look up there. I would also consider the "+" to do what "Enter interpreter path" does (it even matches its current icon 😉) before I would think of "+" meaning "Create Environment".

@luabud
Copy link
Member

luabud commented Nov 23, 2022

I like Kartik's idea, but also agree with Brett regarding discoverability.

I'm thinking of two options:

1 - We leave the enter interpreter path entry and add one above with "+ Create a new environment..." option. We would need to replace the icon from the enter interpreter path (it could be either the search icon given most folks use the "browse" option, or maybe the symlink one from https://microsoft.github.io/vscode-codicons/dist/codicon.html?); or
2 - We replace "enter interpreter path" with "+ Create a new environment...", and add a search icon next to refresh button to invoke the "enter interpreter path" option

But ofc happy to hear other ideas or suggestions 😊

@karrtikr
Copy link

I agree, I was thinking of + more as add something to the list, aka create environment/interpreter. I like both the options, we could quickly experiment it up to decide 😉

@karrtikr karrtikr added area-environments Features relating to handling interpreter environments needs PR Ready to be worked on labels Dec 12, 2022
@karrtikr karrtikr removed their assignment Dec 12, 2022
@pfmoore
Copy link

pfmoore commented Oct 27, 2023

The key here is discoverability IMO, as it's already available via the normal command menu, what matters is not having people hunt for it. I found this request because I hit "select interpreter" as the obvious thing to do when I wanted to change from the default, but I'm not sure I would have spotted an unobtrusive "+" at the top.

My preference would be the first option @luabud proposes. I don't think it should force use of the default intepreter, which was what @brettcannon suggested originally, as that's not always the right choice (particularly in light of #22364). Having it work exactly like "Python: New Environment" (including prompting the user for environment type and base interpreter) seems perfectly fine to me.

@luabud
Copy link
Member

luabud commented Nov 9, 2023

To be consistent with Jupyter I think it makes sense to use the + button for the create environment, and then add either the search icon or the folder icon from https://microsoft.github.io/vscode-codicons/dist/codicon.html for the "enter interpreter path" option
image

@karthiknadig
Copy link
Member

karthiknadig commented Jan 20, 2024

Done via #22746

@github-actions github-actions bot removed the needs PR Ready to be worked on label Jan 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

6 participants