Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all commands validate the arguments #697

Closed
DonJayamanne opened this issue Feb 2, 2018 · 1 comment
Closed

Ensure all commands validate the arguments #697

DonJayamanne opened this issue Feb 2, 2018 · 1 comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
May 2018

Comments

@DonJayamanne
Copy link

DonJayamanne commented Feb 2, 2018 •
edited
Loading

When commands are mapped to a keyboard shortcut and executed via the shortcut, an empty object {} is passed into the command handler.

We'll need to ensure all command handlers validate their parameters for types, not just for existence of any argument.

This is necessary only if this behavior is by design (see microsoft/vscode#42851)
@DonJayamanne DonJayamanne added awaiting 2-PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Feb 2, 2018
@DonJayamanne DonJayamanne added this to the February 2018 milestone Feb 2, 2018
@brettcannon brettcannon modified the milestones: February 2018, March 2018 Feb 20, 2018
@brettcannon brettcannon modified the milestones: March 2018, April 2018 Mar 12, 2018
@DonJayamanne DonJayamanne modified the milestones: April 2018, May 2018 Apr 2, 2018
@DonJayamanne
Copy link
Author

Issue has been resolved upstream microsoft/vscode#42851

@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
2 participants
@brettcannon @DonJayamanne