Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When code runner extension gets installed, disable the play button icon immediately #7613

Closed
karrtikr opened this issue Sep 25, 2019 · 1 comment
Closed

When code runner extension gets installed, disable the play button icon immediately #7613

karrtikr opened this issue Sep 25, 2019 · 1 comment
Assignees
@karrtikr
Labels
area-terminal feature-request Request for new features or functionality
Milestone
2019 - October Sp...

Comments

@karrtikr
Copy link

karrtikr commented Sep 25, 2019 •
edited
Loading

Use extensions.onDidChange to figure out if code runner extension is installed, and hide the play button icon immediately.

#7423
@karrtikr karrtikr added feature-request Request for new features or functionality needs PR area-terminal labels Sep 25, 2019
@karrtikr karrtikr added this to the 2019 - October Sprint 1 milestone Sep 25, 2019
@karrtikr karrtikr self-assigned this Sep 25, 2019
@karrtikr karrtikr mentioned this issue Sep 25, 2019
Merged
@ericsnowcurrently ericsnowcurrently self-assigned this Sep 26, 2019
@ericsnowcurrently
Copy link
Member

With the "Code Runner" extension installed, using the latest insiders, I only see the icon provided by the other extension. Ours no longer shows. If I uninstall the "Code Runner" extension then our icon shows up again.

@ghost ghost removed the needs PR label Sep 30, 2019
@ericsnowcurrently ericsnowcurrently removed their assignment Sep 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-terminal feature-request Request for new features or functionality
Projects
None yet
Milestone
2019 - October Sprint 1
Development

No branches or pull requests
2 participants
@ericsnowcurrently @karrtikr