Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons against test items are missing in test explorer #7675

Closed
DonJayamanne opened this issue Sep 29, 2019 · 2 comments
Closed

Icons against test items are missing in test explorer #7675

DonJayamanne opened this issue Sep 29, 2019 · 2 comments
Assignees
@DonJayamanne
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@DonJayamanne
Copy link

DonJayamanne commented Sep 29, 2019 •
edited
Loading

Thanks to the UI tests (WIP, but almost completed) I've managed to identify a regression (caught before it went out).

Left of screen = Insiders Build (broken)
Right of screen = Latest Marketplace (correct)

Problem was caused by a refactor from https://github.com/microsoft/vscode-python/pull/7263/files

testExplorerBug
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team external contributor labels Sep 29, 2019
@DonJayamanne DonJayamanne self-assigned this Sep 29, 2019
@DonJayamanne DonJayamanne mentioned this issue Sep 29, 2019
Merged
@DonJayamanne
Copy link
Author

DonJayamanne commented Sep 29, 2019 •
edited
Loading

@brettcannon @luabud Please bring into sprint as (as unplanned) this will have to be fixed (insiders users will be impacted as well).

@karrtikr
Copy link

karrtikr commented Sep 30, 2019 •
edited
Loading

It is in the sprint.😉 Dup of #7586.

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DonJayamanne @karrtikr