Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename python.pythonPath settings #8646

Closed
ksamuel opened this issue Nov 18, 2019 · 3 comments
Closed

Rename python.pythonPath settings #8646

ksamuel opened this issue Nov 18, 2019 · 3 comments
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on

Comments

@ksamuel
Copy link

ksamuel commented Nov 18, 2019

The Python PATH is already a very important concept in Python: it's the official name of the list of paths Python is going to loop over to look up things you import. It's regulated by the sys.path variable, but more importantly, the PYTHONPATH env var.

Worse, it is badly understood by a lot of devs. Having a settings in VSCode named python.pythonPath that is completely unrelated is very confusing, especially for new comers.

Now I understand that it's not desirable to remove the settings completely, but it would be great to phase it out little by little (keeping it as an alias for compat), replacing it with the same one, just named differently.

Suggested name: Python executable

I would also suggest mentioning virtualenv in the help text. Currently it states:

Path to Python, you can use a custom version of Python by modifying this setting to include the full path.

So beginners have no idea they can set the virtualenv here. In fact, typing "virtualenv" or "venv" in the setting search bar doesn't show this setting, which it should.

I opened a separate but related issue about a UI to set it: #8645

@ksamuel ksamuel added triage-needed Needs assignment to the proper sub-team feature-request Request for new features or functionality labels Nov 18, 2019
@brettcannon brettcannon changed the title Rename Python.path settings Rename python.pythonPath settings Nov 19, 2019
@brettcannon brettcannon added area-environments Features relating to handling interpreter environments needs decision and removed triage-needed Needs assignment to the proper sub-team labels Nov 19, 2019
@brettcannon
Copy link
Member

Thank you for the suggestion! We have marked this issue as "needs decision" to make sure we have a conversation about your idea. We plan to leave this feature request open for at least a month to see how many 👍 votes the opening comment gets to help us make our decision.

This is also implicitly covered by #2126 by making the setting less important.

@luabud
Copy link
Member

luabud commented Jan 11, 2020

I agree, that's not the best name for the setting.

#2125 for reference.

@luabud
Copy link
Member

luabud commented Aug 19, 2022

Closing as the setting is now called defaultInterpreterPath

@luabud luabud closed this as completed Aug 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments feature-request Request for new features or functionality needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

4 participants