YAPF applies custom column length wrong on the first save (and correct on the second one)

[courteouselk]

Environment data

• VS Code version: 1.21.1
• Python Extension version: 2018.1
• OS and version: Microsoft Windows [Version 10.0.14393]
• Python Version: 3.6.3
• Relevant/affected Python packages and their versions: pep8 (1.7.1), yapf (0.20.2), pycodestyle (2.3.1)

Actual behavior

After saving a file YAPF first reformats it using default 80 characters column limit, but then after saving the same file for the second time (without any changes) the actually configured column limit is applied (120 in my case) and the file is reformatted again.

I have the following setup.cfg:

[pep8]
max-line-length = 120

[pycodestyle]
max-line-length = 120

[yapf]
based_on_style = pep8
column_limit = 120

.. and the following user settings:

    "python.linting.enabled": true,
    "python.linting.pylintEnabled": false,
    "python.linting.pep8Enabled": true,
    "python.linting.pep8Path": "pycodestyle",
    "python.formatting.provider": "yapf",
    "[python]": { "editor.formatOnSave": true },

Expected behavior

Automatic formatting should by applied right first time.

Steps to reproduce:

• Configure VS Code as per above snippets.
• Create a file test.py with the following contents:

def foo():
    foo = ['f', 'o', 'o', ' ', 'f', 'o', 'o', ' ', 'f', 'o', 'o', ' ', 'f', 'o', 'o', ' ', 'f', 'o', 'o', ' ', 'f', 'o', 'o', ' ']
    return foo

• Save it once, save it twice.

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

none

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)

none

Screenshot

[courteouselk]

If I inject the column limit directly into YAPF command line like this (goes into user settings):

"python.formatting.yapfArgs": ["--style={ based_on_style: pep8, column_limit: 120 }"],

.. then I get the correct behavior.

[patrys]

This is duplicate of #730

[DonJayamanne]

Agreed, closing as a duplicate