Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remote explorer contributed view to use Welcome views #3504

Closed
3 tasks done
alexr00 opened this issue Aug 12, 2020 · 6 comments
Closed
3 tasks done

Migrate remote explorer contributed view to use Welcome views #3504

alexr00 opened this issue Aug 12, 2020 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan remote-explorer
Milestone

Comments

@alexr00
Copy link
Member

alexr00 commented Aug 12, 2020

We now have a better way to show welcome/getting started/empty content in a view with Welcome views. We should convert the remote extensions to use the better UX.

  • Containers
  • WSL
  • SSH
@alexr00 alexr00 added feature-request Request for new features or functionality remote-explorer labels Aug 12, 2020
@alexr00 alexr00 added this to the August 2020 milestone Aug 12, 2020
@alexr00 alexr00 self-assigned this Aug 12, 2020
@alexr00
Copy link
Member Author

alexr00 commented Aug 12, 2020

For containers, when docker isn't running (docker link is to https://code.visualstudio.com/docs/remote/containers):
recording (14)
And when docker is running, but there are no containers (if no folder is open, the first button won't show).
image

@alexr00
Copy link
Member Author

alexr00 commented Aug 13, 2020

Welcome views for WSL.

When WSL is not found:
image

When WSL is installed but there are no distros:
image

@alexr00
Copy link
Member Author

alexr00 commented Aug 13, 2020

For SSH:
image

@alexr00 alexr00 closed this as completed Aug 14, 2020
@bamurtaugh
Copy link
Member

This is a really great idea, thank you for implementing it!

I wonder if we might want to adjust the wording when the WSL executable isn't found since users might not know what the "WSL executable" is and might think it's referring to the Remote WSL extension itself. Maybe something similar to the containers message, "Get started with Remote - WSL by installing the Windows Subsystem for Linux or by visiting the help section."

Or a couple other ideas: "WSL has not been installed..." "You haven't installed WSL on your machine..." or, "WSL executable not found. Get started by first installing the Windows Subsystem for Linux on your machine, or visit the help section to learn more."

Also, I recognize this issue is now closed, so I'm more than happy to discuss offline or in a new issue!

@alexr00
Copy link
Member Author

alexr00 commented Aug 17, 2020

@bamurtaugh feedback here is great!

I've changed it to "Get started with WSL by installing the Windows Subsystem for Linux or by visiting the help view." As you say, it is more consistent with containers and a little more friendly.

@bamurtaugh
Copy link
Member

@alexr00 That sounds great! Thanks for making this contribution, I think it will provide some really helpful insights to users.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan remote-explorer
Projects
None yet
Development

No branches or pull requests

2 participants