Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up default shell from /etc/passwd if $SHELL not set and not overridden in VS Code settings #521

Closed
Chuxel opened this issue May 30, 2019 · 0 comments
Assignees
Labels
containers Issue in vscode-remote containers plan-item A plan item
Milestone

Comments

@Chuxel
Copy link
Member

Chuxel commented May 30, 2019

Right now the default behavior in the Remote - Containers case (and likely in others) is to drop to sh because the $SHELL environment variable is not set.

We've updated dev container definitions to set this environment variable to bash, but a better way is to get the default shell for the current user via /etc/passwd instead.

This likely affects SSH and WSL in some cases as well, but it is most obvious in the containers case due to how images are typically set up.

@Chuxel Chuxel added the feature-request Request for new features or functionality label May 30, 2019
@chrmarti chrmarti added the containers Issue in vscode-remote containers label May 31, 2019
@chrmarti chrmarti added this to the June 2019 milestone Jun 4, 2019
@chrmarti chrmarti closed this as completed Jun 7, 2019
@chrmarti chrmarti added plan-item A plan item and removed feature-request Request for new features or functionality labels Jun 24, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers plan-item A plan item
Projects
None yet
Development

No branches or pull requests

2 participants