Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create terminal only when requested #736

Closed
Tyriar opened this issue Jun 19, 2019 · 3 comments
Closed

Create terminal only when requested #736

Tyriar opened this issue Jun 19, 2019 · 3 comments
Assignees
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 19, 2019

microsoft/vscode#75290

There's a new terminal option that can completely hide the terminal from the user, for ssh that means all the setup/connection stuff can happen only in output and notifications unless the user clicks for more detail. For containers the same could be true where the terminal that sets up the container is only shown when requested

@Tyriar Tyriar added the containers Issue in vscode-remote containers label Jun 19, 2019
@chrmarti chrmarti added the feature-request Request for new features or functionality label Jun 20, 2019
@chrmarti chrmarti added this to the June 2019 milestone Jun 20, 2019
@chrmarti
Copy link
Contributor

@Tyriar Are there any plans to bring this to TerminalRenderer?

@Tyriar
Copy link
Member Author

Tyriar commented Jun 20, 2019

@chrmarti if you're using a terminal renderer you don't need it do you, you can just cache the data you've received and delay the creation of the terminal renderer?

We could add it to microsoft/vscode#70978 if it made sense to but the above solution is probably better as it would involve less work and memory.

@chrmarti
Copy link
Contributor

Makes sense, I'll look into doing that. Thanks.

@chrmarti chrmarti modified the milestones: June 2019, Backlog Jun 24, 2019
@chrmarti chrmarti changed the title Adopt TerminalOptions.runInBackground in containers Create terminal only when requested Nov 21, 2019
@chrmarti chrmarti modified the milestones: Backlog, November 2019 Nov 21, 2019
@chrmarti chrmarti added the verification-needed Verification of issue is requested label Dec 3, 2019
@mjbvz mjbvz added the verified Verification succeeded label Dec 4, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants