Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a button in port notifications on web for making port public #8442

Closed
alexr00 opened this issue May 4, 2023 · 1 comment · Fixed by microsoft/vscode#182190
Closed

Add a button in port notifications on web for making port public #8442

alexr00 opened this issue May 4, 2023 · 1 comment · Fixed by microsoft/vscode#182190
Assignees
@alexr00
Labels
feature-request Request for new features or functionality remote-explorer verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2023

Comments

@alexr00
Copy link
Member

alexr00 commented May 4, 2023

When the remote allows it (currently just Codespaces) and we know that a localhost url won't work (currently browser) we should offer a quick way for users to make a port public.
@alexr00 alexr00 added feature-request Request for new features or functionality remote-explorer labels May 4, 2023
@alexr00 alexr00 added this to the May 2023 milestone May 4, 2023
@alexr00 alexr00 self-assigned this May 4, 2023
@kieferrm kieferrm mentioned this issue May 9, 2023
Closed
15 tasks
@alexr00 alexr00 mentioned this issue May 11, 2023
Merged
@alexr00 alexr00 closed this as completed May 12, 2023
@alexr00 alexr00 added the verification-needed Verification of issue is requested label May 26, 2023
@alexr00
Copy link
Member Author

alexr00 commented May 26, 2023

To verify:

  1. Connect to a Codespace in a browser (not desktop)
  2. Start a process that listens on a port in the Codespaces
  3. Verify that the port notification shows and has a "Make Public" button

@roblourens roblourens added the verified Verification succeeded label May 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality remote-explorer verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

Add option to make port public in notification microsoft/vscode
2 participants
@roblourens @alexr00