Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] Make remote URI unique to trust workspace only once #1275

Closed
1 of 2 tasks
sevillal opened this issue Sep 17, 2021 · 4 comments
Closed
1 of 2 tasks

[Problem] Make remote URI unique to trust workspace only once #1275

sevillal opened this issue Sep 17, 2021 · 4 comments

Comments

@sevillal
Copy link
Contributor

sevillal commented Sep 17, 2021

Currently our remote URI contains ids that are changed even when connecting to the same target:

telemetryTrackingId
sessionId

This causes that everytime we connect to the remote target the trusted workspace prompt is shown.

Related to: #1102

Workaround

@tbombach
Copy link
Member

One possible solution would be to treat these values similar to how we pass authentication info (via the main<->remote extension API), which bypasses the URI.

Let's also follow up with VSCode to see if they are working on a way to pass parameters without it being part of the parameters that we send in the URI

@tbombach tbombach added this to the 0.6.27 Release milestone Sep 23, 2021
@sevillal sevillal changed the title Make remote URI unique to trust workspace only once [Problem] Make remote URI unique to trust workspace only once Sep 23, 2021
@tbombach tbombach mentioned this issue Dec 2, 2021
22 tasks
@sevillal
Copy link
Contributor Author

VS Code issue open: microsoft/vscode#140943

@sevillal
Copy link
Contributor Author

sevillal commented Jan 21, 2022

Updates:

@shsuman
Copy link
Member

shsuman commented Apr 4, 2022

Closing this as it has been fixed in latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants