Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Non-Semver Engine Versions in VSCE Validation and Comparison #1077

Closed
mohankumarelec opened this issue Nov 9, 2024 · 0 comments · Fixed by #1078
Closed

Support Non-Semver Engine Versions in VSCE Validation and Comparison #1077

mohankumarelec opened this issue Nov 9, 2024 · 0 comments · Fixed by #1078
Assignees
Labels
author-verification-requested feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@mohankumarelec
Copy link
Contributor

The Regex used for checking valid engine version, can have values like 1.96.x, which is not a valid semver.
When using these kinds of version, the semver version comparison fails.

if (!/^\*$|^(\^|>=)?((\d+)|x)\.((\d+)|x)\.((\d+)|x)(\-.*)?$/.test(version)) {
throw new Error(`Invalid vscode engine compatibility version '${version}'`);
}

if (engineVersion !== 'latest' && !semver.satisfies(engineVersion, '>=1.61', { includePrerelease: true })) {

@benibenj benibenj added the feature-request Request for new features or functionality label Nov 25, 2024
@benibenj benibenj added this to the January 2025 milestone Nov 25, 2024
@benibenj benibenj added verification-needed Verification of issue is requested author-verification-requested labels Jan 28, 2025
@connor4312 connor4312 added the verified Verification succeeded label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author-verification-requested feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants