Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

A11y_VscodeWebviewUiToolkit_AllComponents_DataGrid_Reflow: The column headers of data grids are not visible properly at 400% zoom. #189

Closed
Shivamd1 opened this issue Aug 30, 2021 · 13 comments · Fixed by #208
Assignees
Labels
accessibility There's an accessibility issue bug Something isn't working
Milestone

Comments

@Shivamd1
Copy link

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHubTags: #A11yMAS;#A11yTCS;#A11ySev2;#SH_VscodeWebviewUiToolkit_Aug2021;#Webview UI Toolkit for Visual Studio Code;#Win32;#FTP;#DesktopApp;#WCAG1.4.10;#Zoom;#AINotInScope;#A11yWCAG2.1;

Environment Details:

Application Name: Vscode Webview Ui Toolkit
Windows Version: Win10

Prerequisite:

Set resolution to 1280*1024
Zoom in to 400%

Repro Steps:

  1. Launch VS Code
  2. Open WebView UI Toolkit: All Component extension
  3. Tab to data grid and observe if all the column headers of data grids are visible properly at 400% zoom.

Actual:

The column headers of data grid are not visible properly at 400% zoom. The column headers are only visible as C.... .

Expected:

The column headers of data grid should be properly visible properly at 400% zoom.

User Impact:

Low vision users will not get the proper information about the data grids.

@Shivamd1 Shivamd1 added the bug Something isn't working label Aug 30, 2021
@hawkticehurst hawkticehurst added the accessibility There's an accessibility issue label Aug 30, 2021
@hawkticehurst
Copy link
Member

hawkticehurst commented Sep 9, 2021

@Shivamd1 Could you explain a bit more of what properly visible means in this context?

Does this mean the column header text should be entirely visible (i.e. not condensed/concatenated at all) or does only a part of the text need to be visible? If only a part needs to be visible, how much? Thanks!

@Shivamd1
Copy link
Author

@hawkticehurst I will provide you the screenshot offline for more clarification

@Shivamd1
Copy link
Author

Please provide build when fixes are done

@hawkticehurst
Copy link
Member

@Shivamd1 I've opened a PR with a fix for this issue and will be sending you a new build shortly.

@hawkticehurst
Copy link
Member

hawkticehurst commented Sep 29, 2021

@Shivamd1 Can you confirm if this bug has been fixed? I sent you a build with the updates about a week and a half ago. Thanks!

@Shivamd1
Copy link
Author

verified and the issue provided observation offline

@hawkticehurst
Copy link
Member

@Shivamd1 I've sent an updated build with a fix to your observations!

@Shivamd1
Copy link
Author

Shivamd1 commented Oct 6, 2021

@hawkticehurst the issue with the data grid is solved now but the panel grids still have the issue

@daviddossett
Copy link
Collaborator

@Shivamd1 were you able to verify the panel issue as fixed? I sent it in the same build as the progress ring fix.

@hawkticehurst
Copy link
Member

Hey @Shivamd1, checking in again to see if you have verified that the panel issue has been fixed? Thanks!

@Shivamd1
Copy link
Author

Shivamd1 commented Dec 7, 2021

@hawkticehurst Verified and the issue does not repro closing the bug

@Shivamd1 Shivamd1 closed this as completed Dec 7, 2021
@hawkticehurst
Copy link
Member

Thanks!

@fsteffi
Copy link

fsteffi commented Feb 2, 2023

GithubTags:#Closed;

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility There's an accessibility issue bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants