From 3831ef5e2ca82e7040cca4af44d76d064f9430a5 Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Thu, 28 Sep 2017 10:17:17 +0200 Subject: [PATCH] Revert "Fix compilations" This reverts commit f1d9958406d6a885876f9bfe6c7d60f7be3744c5. --- src/vs/editor/standalone/browser/simpleServices.ts | 3 --- .../configuration/test/common/testConfigurationService.ts | 4 ---- .../telemetry/test/electron-browser/telemetryService.test.ts | 3 +-- .../test/electron-browser/terminalConfigHelper.test.ts | 1 - .../test/node/configurationResolverService.test.ts | 1 - 5 files changed, 1 insertion(+), 11 deletions(-) diff --git a/src/vs/editor/standalone/browser/simpleServices.ts b/src/vs/editor/standalone/browser/simpleServices.ts index 2d62d8ec97971..bad64ca55aea1 100644 --- a/src/vs/editor/standalone/browser/simpleServices.ts +++ b/src/vs/editor/standalone/browser/simpleServices.ts @@ -433,9 +433,6 @@ export class SimpleConfigurationService implements IConfigurationService { private _onDidUpdateConfiguration = new Emitter(); public onDidUpdateConfiguration: Event = this._onDidUpdateConfiguration.event; - private _onDidRegisterExtensionsConfigurations = new Emitter(); - public onDidRegisterExtensionsConfigurations: Event = this._onDidRegisterExtensionsConfigurations.event; - private _configuration: Configuration; constructor() { diff --git a/src/vs/platform/configuration/test/common/testConfigurationService.ts b/src/vs/platform/configuration/test/common/testConfigurationService.ts index e222b49c4ad85..976cb5840ad20 100644 --- a/src/vs/platform/configuration/test/common/testConfigurationService.ts +++ b/src/vs/platform/configuration/test/common/testConfigurationService.ts @@ -52,10 +52,6 @@ export class TestConfigurationService extends EventEmitter implements IConfigura return { dispose() { } }; } - public onDidRegisterExtensionsConfigurations() { - return { dispose() { } }; - } - public lookup(key: string, overrides?: IConfigurationOverrides): IConfigurationValue { const config = this.getConfiguration(undefined, overrides); diff --git a/src/vs/platform/telemetry/test/electron-browser/telemetryService.test.ts b/src/vs/platform/telemetry/test/electron-browser/telemetryService.test.ts index fc484a8135387..494159a5f564e 100644 --- a/src/vs/platform/telemetry/test/electron-browser/telemetryService.test.ts +++ b/src/vs/platform/telemetry/test/electron-browser/telemetryService.test.ts @@ -698,8 +698,7 @@ suite('TelemetryService', () => { }, keys() { return { default: [], user: [], workspace: [], folder: [] }; }, values() { return {}; }, - onDidUpdateConfiguration: emitter.event, - onDidRegisterExtensionsConfigurations: new Emitter().event, + onDidUpdateConfiguration: emitter.event }); assert.equal(service.isOptedIn, false); diff --git a/src/vs/workbench/parts/terminal/test/electron-browser/terminalConfigHelper.test.ts b/src/vs/workbench/parts/terminal/test/electron-browser/terminalConfigHelper.test.ts index d5d820d02fe2b..e95533d078f29 100644 --- a/src/vs/workbench/parts/terminal/test/electron-browser/terminalConfigHelper.test.ts +++ b/src/vs/workbench/parts/terminal/test/electron-browser/terminalConfigHelper.test.ts @@ -24,7 +24,6 @@ class MockConfigurationService implements IConfigurationService { public getConfiguration(): any { return this.configuration; } public getConfigurationData(): any { return null; } public onDidUpdateConfiguration() { return { dispose() { } }; } - public onDidRegisterExtensionsConfigurations() { return { dispose() { } }; } } suite('Workbench - TerminalConfigHelper', () => { diff --git a/src/vs/workbench/services/configurationResolver/test/node/configurationResolverService.test.ts b/src/vs/workbench/services/configurationResolver/test/node/configurationResolverService.test.ts index af4176594c499..7841abf9606db 100644 --- a/src/vs/workbench/services/configurationResolver/test/node/configurationResolverService.test.ts +++ b/src/vs/workbench/services/configurationResolver/test/node/configurationResolverService.test.ts @@ -355,7 +355,6 @@ class MockConfigurationService implements IConfigurationService { public getConfiguration(): any { return this.configuration; } public getConfigurationData(): any { return null; } public onDidUpdateConfiguration() { return { dispose() { } }; } - public onDidRegisterExtensionsConfigurations() { return { dispose() { } }; } } class MockCommandService implements ICommandService {