From 9243c3db85d51288a8c92ecac388c2952c564929 Mon Sep 17 00:00:00 2001 From: Logan Ramos Date: Thu, 28 Mar 2024 10:30:08 -0700 Subject: [PATCH] Ensure no disposables leak (#209040) --- .eslintrc.json | 1 - .../telemetry/test/browser/1dsAppender.test.ts | 10 +++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index b174b6f348af1..61d778150f15c 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -159,7 +159,6 @@ "src/vs/platform/opener/test/common/opener.test.ts", "src/vs/platform/registry/test/common/platform.test.ts", "src/vs/platform/remote/test/common/remoteHosts.test.ts", - "src/vs/platform/telemetry/test/browser/1dsAppender.test.ts", "src/vs/platform/workspace/test/common/workspace.test.ts", "src/vs/platform/workspaces/test/electron-main/workspaces.test.ts", "src/vs/workbench/api/test/browser/mainThreadConfiguration.test.ts", diff --git a/src/vs/platform/telemetry/test/browser/1dsAppender.test.ts b/src/vs/platform/telemetry/test/browser/1dsAppender.test.ts index 8c16031dede9c..2ee6f9bc99b6c 100644 --- a/src/vs/platform/telemetry/test/browser/1dsAppender.test.ts +++ b/src/vs/platform/telemetry/test/browser/1dsAppender.test.ts @@ -4,6 +4,7 @@ *--------------------------------------------------------------------------------------------*/ import type { ITelemetryItem, ITelemetryUnloadState } from '@microsoft/1ds-core-js'; import * as assert from 'assert'; +import { ensureNoDisposablesAreLeakedInTestSuite } from 'vs/base/test/common/utils'; import { OneDataSystemWebAppender } from 'vs/platform/telemetry/browser/1dsAppender'; import { IAppInsightsCore } from 'vs/platform/telemetry/common/1dsAppender'; @@ -28,14 +29,17 @@ suite('AIAdapter', () => { const prefix = 'prefix'; + teardown(() => { + adapter.flush(); + }); + + ensureNoDisposablesAreLeakedInTestSuite(); + setup(() => { appInsightsMock = new AppInsightsCoreMock(); adapter = new OneDataSystemWebAppender(false, prefix, undefined!, () => appInsightsMock); }); - teardown(() => { - adapter.flush(); - }); test('Simple event', () => { adapter.log('testEvent');