Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make find widget toggles configurable settings #10344

Closed
aybabtme opened this issue Aug 9, 2016 · 6 comments
Closed

Make find widget toggles configurable settings #10344

aybabtme opened this issue Aug 9, 2016 · 6 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations feature-request Request for new features or functionality
Milestone

Comments

@aybabtme
Copy link

aybabtme commented Aug 9, 2016

Related to #4309 (comment)

Add to settings.json a way to always enable the case-sensitivity feature of Find.

@jrieken
Copy link
Member

jrieken commented Aug 9, 2016

Setting? I believe that's stuff we should store and retrieve using the memento stuff...

@alexdima
Copy link
Member

It would be the default value

@alexdima alexdima added feature-request Request for new features or functionality editor editor-find Editor find operations labels Aug 12, 2016
@alexdima alexdima added this to the Backlog milestone Aug 12, 2016
@aybabtme
Copy link
Author

@jrieken not sure what the memento stuff is. As a user, my expectations is that I'd be able to change that in my user settings (the JSON file) and then never have to think about it again.

@alexdima alexdima changed the title Make case insensitivity toggle a configurable settings Make find widget toggles configurable settings Sep 7, 2016
@ramya-rao-a
Copy link
Contributor

Find across files already persists the Find options (case sensitivity, whole word and regex). Find in a single file doesn't. Using configuration setting for default value for Find in File and keeping the existing persisting logic in Find across files will make experience inconsistent.

Can we not use the same persisting logic for Find in File instead of configuration setting?

@stefcameron
Copy link

I'd love to see a setting default for Alt+C (case-sensitive search and match). I'd like to be able to configure Code such that it defaults to case-sensitive search/match, and then be able to use Alt+C to toggle it on/off (but Alt+C should not change my default setting).

@rebornix rebornix self-assigned this Apr 28, 2017
@rebornix
Copy link
Member

rebornix commented May 6, 2017

Let's track the setting persistence in #6158

@rebornix rebornix closed this as completed May 6, 2017
@rebornix rebornix added the *duplicate Issue identified as a duplicate of another issue(s) label May 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-find Editor find operations feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

6 participants