Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Pinning" a dynamic launch configuration removes comments from launch.json #110295

Closed
weinand opened this issue Nov 10, 2020 · 3 comments
Closed

"Pinning" a dynamic launch configuration removes comments from launch.json #110295

weinand opened this issue Nov 10, 2020 · 3 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues

Comments

@weinand
Copy link
Contributor

weinand commented Nov 10, 2020

"Pinning" a dynamic launch configuration(by clicking on the gear icon in the QuickPick) removes comments from launch.json:

2020-11-10_10-30-17 (1)

Adding regular launch configurations via the "Add Configuration..." button does not remove comments:

2020-11-10_10-32-37 (1)
@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Nov 10, 2020
@isidorn
Copy link
Contributor

isidorn commented Nov 10, 2020

This is a known limitation, dup of #99305
There is no api for this in the configuraiton service, thus assigning to backlog.

@isidorn isidorn added this to the Backlog milestone Nov 10, 2020
@weinand
Copy link
Contributor Author

weinand commented Nov 10, 2020

IMO this issue and #99305 are just duplicates of #29453.
You don't have to keep this open and put on backlog.

@isidorn
Copy link
Contributor

isidorn commented Nov 10, 2020

Ok, closing as duplicate
fyi @sandy081

@isidorn isidorn closed this as completed Nov 10, 2020
@weinand weinand removed this from the Backlog milestone Nov 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weinand @isidorn