Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: multiple selections in notebook #117295

Closed
2 tasks done
rebornix opened this issue Feb 22, 2021 · 1 comment
Closed
2 tasks done

Test: multiple selections in notebook #117295

rebornix opened this issue Feb 22, 2021 · 1 comment

Comments

@rebornix
Copy link
Member

rebornix commented Feb 22, 2021

Refs: #114156, #117204

Complexity: 4

Create Issue


The notebook editor is built on top of the List Widget, thus it's natural to add multiple selection support to it. It needs careful design with the API and UX as the notebook interactions are somewhat different from the text editor or file explorer so we are adding multiple selection support gradually. Please test with GitHub Issue Notebook and play with following scenarios:

  • Arrow keys
  • Shift + Click multi selects
  • Copy/Paste/Cut works with multi select
    • After Cut/Paste, the selections are correct
    • After Undo/Redo, the selections are correct
  • API. We are moving to the new NotebookEditor.selections but please check if NotebookEditor.selection is always correct when you change cell selections in the UI. Code snippet you can use
context.subscriptions.push(vscode.window.onDidChangeNotebookEditorSelection(e => {
	console.log(e.notebookEditor.selection);
}))
@rebornix rebornix added this to the February 2021 milestone Feb 22, 2021
@sandy081
Copy link
Member

Removed @joaomoreno as he is not available for testing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants